fixup! util: use more defensive code when inspecting error objects

Author: aduh95

lib/internal/util/inspect.js

@@ -1914,41 +1914,46 @@ function formatError(err, constructor, tag, ctx, keys) {
   let message, name, stack;
   try {
     stack = getStackString(ctx, err);
-    if (!ctx.showHidden && keys.length !== 0) {
-      const index = ArrayPrototypeIndexOf(keys, 'stack');
-      // Only hide the property if it's a string and if it's part of the original stack
-      if (index !== -1) {
-        ArrayPrototypeSplice(keys, index, 1);
-      }
-    }
   } catch {
     return ObjectPrototypeToString(err);
   }
+
+  let messageIsGetterThatThrows = false;
   try {
     message = err.message;
-    if (!ctx.showHidden && keys.length !== 0) {
+  } catch (err2) {
+    messageIsGetterThatThrows = true;
+  }
+  let nameIsGetterThatThrows = false;
+  try {
+    name = err.name;
+  } catch {
+    nameIsGetterThatThrows = true;
+  }
+
+  if (!ctx.showHidden && keys.length !== 0) {
+    const index = ArrayPrototypeIndexOf(keys, 'stack');
+    if (index !== -1) {
+      ArrayPrototypeSplice(keys, index, 1);
+    }
+
+    if (!messageIsGetterThatThrows) {
       const index = ArrayPrototypeIndexOf(keys, 'message');
       // Only hide the property if it's a string and if it's part of the original stack
       if (index !== -1 && (typeof message !== 'string' || StringPrototypeIncludes(stack, message))) {
         ArrayPrototypeSplice(keys, index, 1);
       }
     }
-  } catch {
-    // If message is a getter that throws, we ignore the error.
-  }
-  try {
-    name = err.name;
-    if (!ctx.showHidden && keys.length !== 0) {
+
+    if (!nameIsGetterThatThrows) {
       const index = ArrayPrototypeIndexOf(keys, 'name');
       // Only hide the property if it's a string and if it's part of the original stack
       if (index !== -1 && (typeof name !== 'string' || StringPrototypeIncludes(stack, name))) {
         ArrayPrototypeSplice(keys, index, 1);
       }
     }
-    name ??= 'Error';
-  } catch {
-    name = 'Error';
   }
+  name ??= 'Error';
 
   if ('cause' in err &&
       (keys.length === 0 || !ArrayPrototypeIncludes(keys, 'cause'))) {