Skip to content

Commit 7d52d9c

Browse files
authored
tools: pin OpenSSL to 3.5.4 on test-shared workflow
PR-URL: #60428 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
1 parent 8ea8d4c commit 7d52d9c

File tree

3 files changed

+30
-1
lines changed

3 files changed

+30
-1
lines changed

.github/workflows/test-shared.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# This action uses the following secrets:
2+
# CACHIX_AUTH_TOKEN: Write access to nodejs.cachix.org – without it, the cache is read-only.
13
name: Test Shared libraries
24

35
on:
@@ -95,6 +97,11 @@ jobs:
9597
with:
9698
extra_nix_config: sandbox = true
9799

100+
- uses: cachix/cachix-action@0fc020193b5a1fa3ac4575aa3a7d3aa6a35435ad # v16
101+
with:
102+
name: nodejs
103+
authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
104+
98105
- name: Configure sccache
99106
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
100107
with:

BUILDING.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,12 @@ direnv allow .
270270
make build-ci -j12
271271
```
272272

273+
Most dependencies will likely be available in the official nixpkgs cache,
274+
although for some dependencies we have to deviate for the upstream repository,
275+
in which case those will be built locally, or you can use the Cachix repository
276+
for the project: `cachix use nodejs`. See <https://docs.cachix.org/> for more
277+
information.
278+
273279
The use of `make build-ci` is to ensure you are using the `CONFIG_FLAGS`
274280
environment variable. You can also specify it manually:
275281

shell.nix

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
nghttp2
1313
nghttp3
1414
ngtcp2
15-
openssl
1615
simdjson
1716
simdutf
1817
sqlite
@@ -21,6 +20,23 @@
2120
zstd
2221
;
2322
http-parser = pkgs.llhttp;
23+
openssl = pkgs.openssl.overrideAttrs (old: {
24+
version = "3.5.4";
25+
src = pkgs.fetchurl {
26+
url = builtins.replaceStrings [ old.version ] [ "3.5.4" ] old.src.url;
27+
hash = "sha256-lnMR+ElVMWlpvbHY1LmDcY70IzhjnGIexMNP3e81Xpk=";
28+
};
29+
doCheck = false;
30+
configureFlags = (old.configureFlags or [ ]) ++ [
31+
"no-docs"
32+
"no-tests"
33+
];
34+
outputs = [
35+
"bin"
36+
"out"
37+
"dev"
38+
];
39+
});
2440
},
2541
ccache ? pkgs.ccache,
2642
ninja ? pkgs.ninja,

0 commit comments

Comments
 (0)