build: make HTTP_MAX_HEADER_SIZE configurable

The maximum size of headers introduced in the security release of
2018/11/27 is not configurable. This change adds a
--http-max-header-size option to ./configure.

See: #24693

Author: mcollina

configure.py

@@ -189,6 +189,11 @@
     dest='experimental_http_parser',
     help='use llhttp instead of http_parser')
 
+parser.add_option('--http-max-header-size',
+    action='store',
+    default='8192',
+    help='set the max size of HTTP headers [default: %default]')
+
 shared_optgroup.add_option('--shared-http-parser',
     action='store_true',
     dest='shared_http_parser',
@@ -1594,7 +1599,11 @@ def make_bin_override():
 
 configure_node(output)
 configure_library('zlib', output)
+
+# configure http_parser
 configure_library('http_parser', output)
+output['variables']['http_max_header_size'] = options.http_max_header_size
+
 configure_library('libuv', output)
 configure_library('libcares', output)
 configure_library('nghttp2', output)

deps/http_parser/http_parser.gyp

@@ -47,6 +47,10 @@
     ],
   },
 
+  'variables': {
+    'http_max_header_size%': '8192'
+  },
+
   'targets': [
     {
       'target_name': 'http_parser',
@@ -56,7 +60,7 @@
         'defines': [ 'HTTP_PARSER_STRICT=0' ],
         'include_dirs': [ '.' ],
       },
-      'defines': [ 'HTTP_MAX_HEADER_SIZE=8192', 'HTTP_PARSER_STRICT=0' ],
+      'defines': [ 'HTTP_MAX_HEADER_SIZE=<(http_max_header_size)', 'HTTP_PARSER_STRICT=0' ],
       'sources': [ './http_parser.c', ],
       'conditions': [
         ['OS=="win"', {
@@ -79,7 +83,7 @@
         'defines': [ 'HTTP_PARSER_STRICT=1' ],
         'include_dirs': [ '.' ],
       },
-      'defines': [ 'HTTP_MAX_HEADER_SIZE=8192', 'HTTP_PARSER_STRICT=1' ],
+      'defines': [ 'HTTP_MAX_HEADER_SIZE=<(http_max_header_size)', 'HTTP_PARSER_STRICT=1' ],
       'sources': [ './http_parser.c', ],
       'conditions': [
         ['OS=="win"', {

node.gypi

@@ -8,6 +8,7 @@
   # all obj files in static libs into the executable or shared lib.
   'variables': {
     'variables': {
+      'http_max_header_size%': 8192,
       'variables': {
         'force_load%': 'true',
         'current_type%': '<(_type)',
@@ -168,6 +169,7 @@
       'dependencies': [ 'deps/llhttp/llhttp.gyp:llhttp' ],
     }, {
       'conditions': [ [ 'node_shared_http_parser=="false"', {
+        'defines': [ 'HTTP_MAX_HEADER_SIZE=<(http_max_header_size)' ],
         'dependencies': [ 'deps/http_parser/http_parser.gyp:http_parser' ],
       } ] ],
     } ],