Skip to content

Commit 8321c08

Browse files
Apply suggestions from code review
Co-authored-by: Antoine du Hamel <[email protected]>
1 parent fc77151 commit 8321c08

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

.github/workflows/linters.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,24 +107,23 @@ jobs:
107107
set +e
108108
NODE=$(command -v node) make lint-js
109109
EXIT_CODE="$?"
110-
if [ "$EXIT_CODE" != "0" ]
111-
then
110+
if [ "$EXIT_CODE" != "0" ]; then
112111
echo
113112
echo 'ERROR: The JavaScript lint validation failed (the errors are logged above).'
114113
echo ' Please fix the lint errors.'
115114
if make lint-js-fix > /dev/null 2>&1; then
116115
echo ' Run:'
117116
echo ' make lint-js-fix'
118117
echo ' to fix the lint issues.'
119-
git diff
118+
git diff --no-pager
120119
elif git diff --quiet --exit-code; then
121120
echo ' None of the issue is auto-fixable, so manual fixes for'
122121
echo ' all of the issues are required.'
123122
else
124123
echo ' Run:'
125124
echo ' make lint-js-fix'
126-
echo ' to fix the auto-fixable lint issues'
127-
echo ' note that however some manual fixes are also required.'
125+
echo ' to fix the auto-fixable lint issues.'
126+
echo ' Note that some manual fixes are also required.'
128127
fi
129128
echo
130129
exit "$EXIT_CODE"

0 commit comments

Comments
 (0)