esm: optimize ReferenceError check

  Skip function call for non-ReferenceErrors and reduce optional chaining.

Author: mag123c

lib/internal/modules/esm/module_job.js

@@ -65,7 +65,7 @@ const CJSGlobalLike = [
   '__filename',
   '__dirname',
 ];
-const getUndefinedCJSGlobalLike = (errorMessage) =>
+const findCommonJSGlobalLikeNotDefinedError = (errorMessage) =>
   ArrayPrototypeFind(
     CJSGlobalLike,
     (globalLike) => errorMessage === `${globalLike} is not defined`,
@@ -79,12 +79,12 @@ const getUndefinedCJSGlobalLike = (errorMessage) =>
  * @returns {void}
  */
 const explainCommonJSGlobalLikeNotDefinedError = (e, url, hasTopLevelAwait) => {
-  const undefinedGlobal = getUndefinedCJSGlobalLike(e?.message);
-  if (e?.name === 'ReferenceError' && undefinedGlobal !== null) {
+  const notDefinedGlobalLike = e?.name === 'ReferenceError' && findCommonJSGlobalLikeNotDefinedError(e.message);
+  if (notDefinedGlobalLike) {
 
     if (hasTopLevelAwait) {
       let advice;
-      switch (undefinedGlobal) {
+      switch (notDefinedGlobalLike) {
         case 'require':
           advice = 'replace require() with import';
           break;
@@ -100,7 +100,7 @@ const explainCommonJSGlobalLikeNotDefinedError = (e, url, hasTopLevelAwait) => {
           break;
       }
 
-      e.message = `Cannot determine intended module format because both '${undefinedGlobal}' and top-level await are present. If the code is intended to be CommonJS, wrap await in an async function. If the code is intended to be an ES module, ${advice}.`;
+      e.message = `Cannot determine intended module format because both '${notDefinedGlobalLike}' and top-level await are present. If the code is intended to be CommonJS, wrap await in an async function. If the code is intended to be an ES module, ${advice}.`;
       e.code = 'ERR_AMBIGUOUS_MODULE_SYNTAX';
       return;
     }