src: remove std::array overload of FIXED_ONE_BYTE_STRING

This overload was only used in one place, in a cold path, and in
particular in a place where the compiler would be able to generate
the exact same code using just a call to `.size()`.

Author: addaleax

src/node_os.cc

@@ -260,7 +260,7 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo<Value>& args) {
     result.emplace_back(OneByteString(isolate, ip));
     result.emplace_back(OneByteString(isolate, netmask));
     result.emplace_back(family);
-    result.emplace_back(FIXED_ONE_BYTE_STRING(isolate, mac));
+    result.emplace_back(OneByteString(isolate, mac.data(), mac.size() - 1));
     result.emplace_back(
         Boolean::New(env->isolate(), interfaces[i].is_internal));
     if (interfaces[i].address.address4.sin_family == AF_INET6) {

src/util.h

@@ -356,14 +356,6 @@ inline v8::Local<v8::String> FIXED_ONE_BYTE_STRING(v8::Isolate* isolate,
   return OneByteString(isolate, data, N - 1);
 }
 
-template <std::size_t N>
-  requires(N > 0)
-inline v8::Local<v8::String> FIXED_ONE_BYTE_STRING(
-    v8::Isolate* isolate, const std::array<char, N>& arr) {
-  CHECK_EQ(arr[N - 1], '\0');
-  return OneByteString(isolate, arr.data(), N - 1);
-}
-
 // tolower() is locale-sensitive.  Use ToLower() instead.
 inline char ToLower(char c);
 inline std::string ToLower(const std::string& in);