src: rename config file testRunner to test

PR-URL: #60798
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

Author: marco-ippolito

doc/api/cli.md

@@ -1016,7 +1016,7 @@ in the `$schema` must be replaced with the version of Node.js you are using.
     "watch-path": "src",
     "watch-preserve-output": true
   },
-  "testRunner": {
+  "test": {
     "test-isolation": "process"
   },
   "watch": {
@@ -1029,7 +1029,7 @@ The configuration file supports namespace-specific options:
 
 * The `nodeOptions` field contains CLI flags that are allowed in [`NODE_OPTIONS`][].
 
-* Namespace fields like `testRunner` contain configuration specific to that subsystem.
+* Namespace fields like `test` contain configuration specific to that subsystem.
 
 No-op flags are not supported.
 Not all V8 flags are currently supported.

doc/node-config-schema.json

@@ -655,7 +655,7 @@
         }
       }
     },
-    "testRunner": {
+    "test": {
       "type": "object",
       "additionalProperties": false,
       "properties": {

src/node_config_file.cc

@@ -262,8 +262,20 @@ ParseResult ConfigReader::ParseConfig(const std::string_view& config_path) {
       return ParseResult::InvalidContent;
     }
 
-    // Check if this field is a valid namespace
     std::string namespace_name(field_name);
+
+    // TODO(@marco-ippolito): Remove warning for testRunner namespace
+    if (namespace_name == "testRunner") {
+      FPrintF(stderr,
+              "the \"testRunner\" namespace has been removed. "
+              "Use \"test\" instead.\n");
+      // Better to throw an error than to ignore it
+      // Otherwise users might think their test suite is green
+      // when it's not running
+      return ParseResult::InvalidContent;
+    }
+
+    // Check if this field is a valid namespace
     if (!valid_namespaces.contains(namespace_name)) {
       // If not, skip it
       continue;

src/node_options.h

@@ -415,7 +415,7 @@ std::vector<std::string> MapAvailableNamespaces();
 // Define all namespace entries
 #define OPTION_NAMESPACE_LIST(V)                                               \
   V(kNoNamespace, "")                                                          \
-  V(kTestRunnerNamespace, "testRunner")                                        \
+  V(kTestRunnerNamespace, "test")                                              \
   V(kWatchNamespace, "watch")                                                  \
   V(kPermissionNamespace, "permission")
 

test/fixtures/options-as-flags/test-config.json

@@ -3,7 +3,7 @@
     "experimental-transform-types": true,
     "max-http-header-size": 8192
   },
-  "testRunner": {
+  "test": {
     "test-isolation": "none"
   }
 }

test/fixtures/rc/deprecated-testrunner-namespace.json

@@ -0,0 +1,5 @@
+{
+  "testRunner": {
+    "test-isolation": "none"
+  }
+}

test/fixtures/rc/duplicate-namespace-option/node.config.json

@@ -1,5 +1,5 @@
 {
-    "testRunner": {
+    "test": {
         "test-name-pattern": "first-pattern",
         "test-name-pattern": "second-pattern"
     }

test/fixtures/rc/empty-valid-namespace.json

@@ -1,3 +1,3 @@
 {
-    "testRunner": {}
+    "test": {}
 }

test/fixtures/rc/namespace-with-array.json

@@ -1,5 +1,5 @@
 {
-    "testRunner": {
+    "test": {
         "test-coverage-exclude": ["config-pattern1", "config-pattern2"]
     }
 }

test/fixtures/rc/namespace-with-disallowed-envvar.json

@@ -1,5 +1,5 @@
 {
-    "testRunner": {
+    "test": {
        "test-concurrency": 1,
        "experimental-test-coverage": true
     }