fixup! src: use Utf8Value and TwoByteValue instead of V8 helpers

Author: addaleax

src/api/async_resource.cc

@@ -16,7 +16,8 @@ AsyncResource::AsyncResource(Isolate* isolate,
                              Local<Object> resource,
                              const char* name,
                              async_id trigger_async_id)
-    : AsyncResource(isolate, resource, std::string_view(name), trigger_async_id) {}
+    : AsyncResource(
+          isolate, resource, std::string_view(name), trigger_async_id) {}
 
 AsyncResource::AsyncResource(Isolate* isolate,
                              Local<Object> resource,

src/api/hooks.cc

@@ -12,7 +12,6 @@ using v8::Isolate;
 using v8::Just;
 using v8::Local;
 using v8::Maybe;
-using v8::NewStringType;
 using v8::Nothing;
 using v8::Object;
 using v8::String;
@@ -201,7 +200,8 @@ async_context EmitAsyncInit(Isolate* isolate,
                             Local<Object> resource,
                             const char* name,
                             async_id trigger_async_id) {
-  return EmitAsyncInit(isolate, resource, std::string_view(name), trigger_async_id);
+  return EmitAsyncInit(
+      isolate, resource, std::string_view(name), trigger_async_id);
 }
 
 async_context EmitAsyncInit(Isolate* isolate,
@@ -210,8 +210,8 @@ async_context EmitAsyncInit(Isolate* isolate,
                             async_id trigger_async_id) {
   HandleScope handle_scope(isolate);
   Local<String> type = ToV8Value(isolate->GetCurrentContext(), name, isolate)
-                          .ToLocalChecked()
-                          .As<String>();
+                           .ToLocalChecked()
+                           .As<String>();
   return EmitAsyncInit(isolate, resource, type, trigger_async_id);
 }
 

src/node_buffer.cc

@@ -1007,13 +1007,12 @@ void IndexOfString(const FunctionCallbackInfo<Value>& args) {
                                     offset / 2,
                                     is_forward);
     } else {
-      result =
-          nbytes::SearchString(reinterpret_cast<const uint16_t*>(haystack),
-                               haystack_length / 2,
-                               needle_value.out(),
-                               needle_value.length(),
-                               offset / 2,
-                               is_forward);
+      result = nbytes::SearchString(reinterpret_cast<const uint16_t*>(haystack),
+                                    haystack_length / 2,
+                                    needle_value.out(),
+                                    needle_value.length(),
+                                    offset / 2,
+                                    is_forward);
     }
     result *= 2;
   } else if (enc == UTF8) {
@@ -1022,13 +1021,13 @@ void IndexOfString(const FunctionCallbackInfo<Value>& args) {
       return args.GetReturnValue().Set(-1);
     CHECK_GE(needle_length, needle_value.length());
 
-    result =
-        nbytes::SearchString(reinterpret_cast<const uint8_t*>(haystack),
-                             haystack_length,
-                             reinterpret_cast<const uint8_t*>(needle_value.out()),
-                             needle_length,
-                             offset,
-                             is_forward);
+    result = nbytes::SearchString(
+        reinterpret_cast<const uint8_t*>(haystack),
+        haystack_length,
+        reinterpret_cast<const uint8_t*>(needle_value.out()),
+        needle_length,
+        offset,
+        is_forward);
   } else if (enc == LATIN1) {
     uint8_t* needle_data = node::UncheckedMalloc<uint8_t>(needle_length);
     if (needle_data == nullptr) {

src/node_errors.cc

@@ -1026,8 +1026,11 @@ void PerIsolateMessageListener(Local<Message> message, Local<Value> error) {
       Utf8Value filename(isolate, message->GetScriptOrigin().ResourceName());
       Utf8Value msg(isolate, message->Get());
       // (filename):(line) (message)
-      std::string warning = SPrintF("%s:%s %s",
-        filename, message->GetLineNumber(env->context()).FromMaybe(-1), msg);
+      std::string warning =
+          SPrintF("%s:%s %s",
+                  filename,
+                  message->GetLineNumber(env->context()).FromMaybe(-1),
+                  msg);
       USE(ProcessEmitWarningGeneric(env, warning, "V8"));
       break;
     }

src/permission/permission.cc

@@ -21,7 +21,6 @@ using v8::IntegrityLevel;
 using v8::Local;
 using v8::MaybeLocal;
 using v8::Object;
-using v8::String;
 using v8::Value;
 
 namespace permission {