fix more test assumptions

Author: aduh95

test/parallel/test-child-process-exec-timeout-expire.js

@@ -18,9 +18,10 @@ if (process.argv[2] === 'child') {
   return;
 }
 
-const cmd = `"${process.execPath}" "${__filename}" child`;
+const cmd = '"$NODE" "$FILE" child';
 
 cp.exec(cmd, {
+  env: { NODE: process.execPath, FILE: __filename },
   timeout: kExpiringParentTimer,
 }, common.mustCall((err, stdout, stderr) => {
   console.log('[stdout]', stdout.trim());

test/parallel/test-child-process-execfile.js

@@ -10,7 +10,7 @@ const os = require('os');
 
 const fixture = fixtures.path('exit.js');
 const echoFixture = fixtures.path('echo.js');
-const execOpts = { encoding: 'utf8', shell: true, env: { NODE: process.execPath } };
+const execOpts = { encoding: 'utf8', shell: true, env: { NODE: process.execPath, FIXTURE: fixture } };
 
 {
   execFile(
@@ -46,7 +46,7 @@ const execOpts = { encoding: 'utf8', shell: true, env: { NODE: process.execPath
 
 {
   // Verify the shell option works properly
-  execFile('"$NODE"', [fixture, 0], execOpts, common.mustSucceed());
+  execFile('"$NODE"', ['"$FIXTURE"', 0], execOpts, common.mustSucceed());
 }
 
 {

test/parallel/test-child-process-promisified.js

@@ -8,7 +8,7 @@ const exec = promisify(child_process.exec);
 const execFile = promisify(child_process.execFile);
 
 {
-  const promise = exec(`${process.execPath} -p 42`);
+  const promise = exec('"$NODE" -p 42', { env: { NODE: process.execPath } });
 
   assert(promise.child instanceof child_process.ChildProcess);
   promise.then(common.mustCall((obj) => {

test/parallel/test-fs-read-stream.js

@@ -198,7 +198,7 @@ if (!common.isWindows) {
   const filename = `${tmpdir.path}/foo.pipe`;
   const mkfifoResult = child_process.spawnSync('mkfifo', [filename]);
   if (!mkfifoResult.error) {
-    child_process.exec(`echo "xyz foobar" > '${filename}'`);
+    child_process.exec('echo "xyz foobar" > "$FILE"', { env: { FILE: filename } });
     const stream = new fs.createReadStream(filename, common.mustNotMutateObjectDeep({ end: 1 }));
     stream.data = '';
 

test/parallel/test-stdout-to-file.js

@@ -14,8 +14,7 @@ const tmpFile = path.join(tmpdir.path, 'stdout.txt');
 tmpdir.refresh();
 
 function test(size, useBuffer, cb) {
-  const cmd = `"$NODE" "${
-    useBuffer ? scriptBuffer : scriptString}" ${size} > "${tmpFile}"`;
+  const cmd = `"$NODE" "$SCRIPT" ${size} > "$TMP_FILE"`;
 
   try {
     fs.unlinkSync(tmpFile);
@@ -25,7 +24,11 @@ function test(size, useBuffer, cb) {
 
   console.log(`${size} chars to ${tmpFile}...`);
 
-  childProcess.exec(cmd, { env: { NODE: process.execPath } }, common.mustSucceed(() => {
+  childProcess.exec(cmd, { env: {
+    NODE: process.execPath,
+    SCRIPT: useBuffer ? scriptBuffer : scriptString,
+    TMP_FILE: tmpFile,
+  } }, common.mustSucceed(() => {
     console.log('done!');
 
     const stat = fs.statSync(tmpFile);