Skip to content

Commit 94a2221

Browse files
committed
fix: use node_api_nogc_env instead of napi_env
Fix env parameter for some nogc finalizer functions
1 parent dcc2192 commit 94a2221

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/js-native-api/test_general/test_general.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ static napi_value testNapiTypeof(napi_env env, napi_callback_info info) {
147147
}
148148

149149
static bool deref_item_called = false;
150-
static void deref_item(napi_env env, void* data, void* hint) {
150+
static void deref_item(node_api_nogc_env env, void* data, void* hint) {
151151
(void) hint;
152152

153153
NODE_API_ASSERT_RETURN_VOID(env, data == &deref_item_called,
@@ -166,7 +166,7 @@ static napi_value deref_item_was_called(napi_env env, napi_callback_info info) {
166166

167167
static napi_value wrap_first_arg(napi_env env,
168168
napi_callback_info info,
169-
napi_finalize finalizer,
169+
node_api_basic_finalize finalizer,
170170
void* data) {
171171
size_t argc = 1;
172172
napi_value to_wrap;
@@ -205,7 +205,7 @@ static napi_value remove_wrap(napi_env env, napi_callback_info info) {
205205
}
206206

207207
static bool finalize_called = false;
208-
static void test_finalize(napi_env env, void* data, void* hint) {
208+
static void test_finalize(node_api_nogc_env env, void* data, void* hint) {
209209
finalize_called = true;
210210
}
211211

@@ -272,7 +272,7 @@ static const char* env_cleanup_finalizer_messages[] = {
272272
"second wrap"
273273
};
274274

275-
static void cleanup_env_finalizer(napi_env env, void* data, void* hint) {
275+
static void cleanup_env_finalizer(node_api_nogc_env env, void* data, void* hint) {
276276
(void) env;
277277
(void) hint;
278278

0 commit comments

Comments
 (0)