fixup! repl: move completion logic to internal module

remove replBuiltinLibsWrapper

Author: dario-piotrowicz

lib/internal/repl/completion.js

@@ -34,7 +34,7 @@ const {
   kContextId,
   getREPLResourceName,
   globalBuiltins,
-  replBuiltinLibsWrapper,
+  getReplBuiltinLibs,
   fixReplRequire,
 } = require('internal/repl/utils');
 
@@ -77,8 +77,7 @@ fixReplRequire(module);
 
 const { BuiltinModule } = require('internal/bootstrap/realm');
 
-const nodeSchemeBuiltinLibs = ArrayPrototypeMap(
-  replBuiltinLibsWrapper._builtinLibs, (lib) => `node:${lib}`);
+const nodeSchemeBuiltinLibs = ArrayPrototypeMap(getReplBuiltinLibs(), (lib) => `node:${lib}`);
 ArrayPrototypeForEach(
   BuiltinModule.getSchemeOnlyModuleNames(),
   (lib) => ArrayPrototypePush(nodeSchemeBuiltinLibs, `node:${lib}`),
@@ -275,7 +274,7 @@ function complete(line, callback) {
       }
     }
 
-    ArrayPrototypePush(completionGroups, replBuiltinLibsWrapper._builtinLibs, nodeSchemeBuiltinLibs);
+    ArrayPrototypePush(completionGroups, getReplBuiltinLibs(), nodeSchemeBuiltinLibs);
   } else if ((match = RegExpPrototypeExec(importRE, line)) !== null) {
     // import('...<Tab>')
     completeOn = match[1];
@@ -339,7 +338,7 @@ function complete(line, callback) {
       }
     }
 
-    ArrayPrototypePush(completionGroups, replBuiltinLibsWrapper._builtinLibs, nodeSchemeBuiltinLibs);
+    ArrayPrototypePush(completionGroups, getReplBuiltinLibs(), nodeSchemeBuiltinLibs);
   } else if ((match = RegExpPrototypeExec(fsAutoCompleteRE, line)) !== null &&
              this.allowBlockingCompletions) {
     ({ 0: completionGroups, 1: completeOn } = completeFSFunctions(match));

lib/internal/repl/utils.js

@@ -818,12 +818,18 @@ function getREPLResourceName() {
 const globalBuiltins =
   new SafeSet(vm.runInNewContext('Object.getOwnPropertyNames(globalThis)'));
 
-const replBuiltinLibsWrapper = {
-  _builtinLibs: ArrayPrototypeFilter(
-    CJSModule.builtinModules,
-    (e) => e[0] !== '_' && !StringPrototypeStartsWith(e, 'node:'),
-  ),
-};
+let _builtinLibs = ArrayPrototypeFilter(
+  CJSModule.builtinModules,
+  (e) => e[0] !== '_' && !StringPrototypeStartsWith(e, 'node:'),
+);
+
+function getReplBuiltinLibs() {
+  return _builtinLibs;
+}
+
+function setReplBuiltinLibs(value) {
+  _builtinLibs = value;
+}
 
 module.exports = {
   REPL_MODE_SLOPPY: Symbol('repl-sloppy'),
@@ -837,6 +843,7 @@ module.exports = {
   kContextId,
   getREPLResourceName,
   globalBuiltins,
-  replBuiltinLibsWrapper,
+  getReplBuiltinLibs,
+  setReplBuiltinLibs,
   fixReplRequire,
 };

lib/repl.js

@@ -152,7 +152,8 @@ const {
   kContextId,
   getREPLResourceName,
   globalBuiltins,
-  replBuiltinLibsWrapper,
+  getReplBuiltinLibs,
+  setReplBuiltinLibs,
   fixReplRequire,
 } = require('internal/repl/utils');
 const {
@@ -1399,31 +1400,31 @@ module.exports = {
 ObjectDefineProperty(module.exports, 'builtinModules', {
   __proto__: null,
   get: pendingDeprecation ? deprecate(
-    () => replBuiltinLibsWrapper._builtinLibs,
+    () => getReplBuiltinLibs(),
     'repl.builtinModules is deprecated. Check module.builtinModules instead',
     'DEP0191',
-  ) : () => replBuiltinLibsWrapper._builtinLibs,
+  ) : () => getReplBuiltinLibs(),
   set: pendingDeprecation ? deprecate(
-    (val) => replBuiltinLibsWrapper._builtinLibs = val,
+    (val) => setReplBuiltinLibs(val),
     'repl.builtinModules is deprecated. Check module.builtinModules instead',
     'DEP0191',
-  ) : (val) => replBuiltinLibsWrapper._builtinLibs = val,
+  ) : (val) => setReplBuiltinLibs(val),
   enumerable: false,
   configurable: true,
 });
 
 ObjectDefineProperty(module.exports, '_builtinLibs', {
   __proto__: null,
   get: pendingDeprecation ? deprecate(
-    () => replBuiltinLibsWrapper._builtinLibs,
+    () => getReplBuiltinLibs(),
     'repl._builtinLibs is deprecated. Check module.builtinModules instead',
     'DEP0142',
-  ) : () => replBuiltinLibsWrapper._builtinLibs,
+  ) : () => getReplBuiltinLibs(),
   set: pendingDeprecation ? deprecate(
-    (val) => replBuiltinLibsWrapper._builtinLibs = val,
+    (val) => setReplBuiltinLibs(val),
     'repl._builtinLibs is deprecated. Check module.builtinModules instead',
     'DEP0142',
-  ) : (val) => replBuiltinLibsWrapper._builtinLibs = val,
+  ) : (val) => setReplBuiltinLibs(val),
   enumerable: false,
   configurable: true,
 });