fixup! fs: add c++ fast path for writeFileSync utf8

Author: CanadaHonk

benchmark/fs/bench-writeFileSync.js

@@ -15,7 +15,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, encoding, stringLength, hasFileDescriptor }) {
   const enc = encoding === 'undefined' ? undefined : encoding;
-  const path = tmpdir.resolve(`.writefilesync-file-${process.pid}`);
+  const path = tmpdir.resolve(`.writefilesync-file-${Date.now()}`);
 
   const useFd = hasFileDescriptor === 'true';
   const file = useFd ? fs.openSync(path, 'w') : path;
@@ -24,14 +24,9 @@ function main({ n, encoding, stringLength, hasFileDescriptor }) {
 
   bench.start();
   for (let i = 0; i < n; ++i) {
-    try {
-      fs.writeFileSync(file, data, enc);
-    } catch {
-      // do nothing
-    }
+    fs.writeFileSync(file, data, enc);
   }
   bench.end(n);
 
-  fs.unlinkSync(path);
   if (useFd) fs.closeSync(file);
 }

src/node_file.cc

@@ -2533,8 +2533,12 @@ static void WriteFileUtf8(const FunctionCallbackInfo<Value>& args) {
   uv_buf_t uvbuf = uv_buf_init(*value, value.length());
 
   FS_SYNC_TRACE_BEGIN(write);
-  uv_fs_write(nullptr, &req, file, &uvbuf, 1, 0, nullptr);
+  int err = uv_fs_write(nullptr, &req, file, &uvbuf, 1, 0, nullptr);
   FS_SYNC_TRACE_END(write);
+
+  if (err < 0) {
+    return env->ThrowUVException(err, "write");
+  }
 }
 
 /*