quic: fixup errant LocalVector usage

jasnell · aduh95 · commit 9b13207f3f0e · 2025-01-28T00:26:22.000+01:00
PR-URL: #56564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
diff --git a/src/quic/session.cc b/src/quic/session.cc
@@ -2728,7 +2728,7 @@ void Session::EmitVersionNegotiation(const ngtcp2_pkt_hd& hd,
 
   LocalVector<Value> versions(env()->isolate(), nsv);
   for (size_t n = 0; n < nsv; n++) {
-    versions.push_back(Integer::NewFromUnsigned(env()->isolate(), sv[n]));
+    versions[n] = Integer::NewFromUnsigned(env()->isolate(), sv[n]);
   }
 
   // supported are the versions we acutually support expressed as a range.

Original file line number	Diff line number	Diff line change
`@@ -2728,7 +2728,7 @@ void Session::EmitVersionNegotiation(const ngtcp2_pkt_hd& hd,`
`2728`	`2728`
`2729`	`2729`	`LocalVector<Value> versions(env()->isolate(), nsv);`
`2730`	`2730`	`for (size_t n = 0; n < nsv; n++) {`
`2731`		`- versions.push_back(Integer::NewFromUnsigned(env()->isolate(), sv[n]));`
	`2731`	`+ versions[n] = Integer::NewFromUnsigned(env()->isolate(), sv[n]);`
`2732`	`2732`	`}`
`2733`	`2733`
`2734`	`2734`	`// supported are the versions we acutually support expressed as a range.`