test: fix inspector uri-encoded paths

Author: kapouer

test/common/inspector-helper.js

@@ -175,7 +175,7 @@ class InspectorSession {
         this._scriptsIdsByUrl.set(scriptId, url);
         const fileUrl = url.startsWith('file:') ?
           url : pathToFileURL(url).toString();
-        if (fileUrl === this.scriptURL().toString()) {
+        if (decodeURIComponent(fileUrl) === decodeURIComponent(this.scriptURL().toString())) {
           this.mainScriptId = scriptId;
         }
       }

test/parallel/test-inspector-async-context-brk.js

@@ -35,7 +35,7 @@ async function test() {
   await new Promise((resolve, reject) => {
     session.post('Debugger.setBreakpointByUrl', {
       'lineNumber': 22,
-      'url': pathToFileURL(path.resolve(__dirname, __filename)).toString(),
+      'url': decodeURIComponent(pathToFileURL(path.resolve(__dirname, __filename)).toString()),
       'columnNumber': 0,
       'condition': ''
     }, (error, result) => {

test/parallel/test-inspector-bindings.js

@@ -86,7 +86,7 @@ function testSampleDebugSession() {
   session.post('Debugger.enable', () => cbAsSecondArgCalled = true);
   session.post('Debugger.setBreakpointByUrl', {
     'lineNumber': 13,
-    'url': pathToFileURL(path.resolve(__dirname, __filename)).toString(),
+    'url': decodeURIComponent(pathToFileURL(path.resolve(__dirname, __filename)).toString()),
     'columnNumber': 0,
     'condition': ''
   });

test/parallel/test-inspector-multisession-js.js

@@ -34,7 +34,7 @@ async function test() {
   await new Promise((resolve, reject) => {
     session1.post('Debugger.setBreakpointByUrl', {
       'lineNumber': 12,
-      'url': pathToFileURL(path.resolve(__dirname, __filename)).toString(),
+      'url': decodeURIComponent(pathToFileURL(path.resolve(__dirname, __filename)).toString()),
       'columnNumber': 0,
       'condition': ''
     }, (error, result) => {

test/parallel/test-inspector-uriencode~d.js

@@ -0,0 +1,67 @@
+'use strict';
+const common = require('../common');
+
+common.skipIfInspectorDisabled();
+
+const assert = require('assert');
+const { Session } = require('inspector');
+const path = require('path');
+const { pathToFileURL } = require('url');
+
+function debugged() {
+  return 42;
+}
+
+async function test() {
+  // Check without properly decoding
+  const session1 = new Session();
+  session1.connect();
+  let session1Paused = false;
+  session1.on('Debugger.paused', () => session1Paused = true);
+  session1.post('Debugger.enable');
+
+  await new Promise((resolve, reject) => {
+    session1.post('Debugger.setBreakpointByUrl', {
+      'lineNumber': 12,
+      'url': pathToFileURL(path.resolve(__dirname, __filename)).toString(),
+      'columnNumber': 0,
+      'condition': ''
+    }, (error, result) => {
+      return error ? reject(error) : resolve(result);
+    });
+  });
+
+  debugged();
+
+  assert(!session1Paused);
+  session1.disconnect();
+
+  // Check correctly with another session
+  let session2Paused = false;
+  const session2 = new Session();
+  session2.connect();
+  session2.on('Debugger.paused', () => session2Paused = true);
+  session2.post('Debugger.enable');
+
+  await new Promise((resolve, reject) => {
+    session2.post('Debugger.setBreakpointByUrl', {
+      'lineNumber': 12,
+      'url': decodeURIComponent(pathToFileURL(path.resolve(__dirname, __filename)).toString()),
+      'columnNumber': 0,
+      'condition': ''
+    }, (error, result) => {
+      return error ? reject(error) : resolve(result);
+    });
+  });
+
+  debugged();
+
+  assert(session2Paused);
+  session2.disconnect();
+}
+
+const interval = setInterval(() => {}, 1000);
+test().then(common.mustCall(() => {
+  clearInterval(interval);
+  console.log('Done!');
+}));