remove writeFileSync debugging

Author: JakobJingleheimer

lib/internal/modules/esm/hooks.js

@@ -66,7 +66,6 @@ const {
 let debug = require('internal/util/debuglog').debuglog('esm', (fn) => {
   debug = fn;
 });
-const { writeFileSync } = require('fs');
 
 
 let importMetaInitializer;
@@ -128,16 +127,12 @@ class Hooks {
    */
   async register(urlOrSpecifier, parentURL, data) {
     const moduleLoader = require('internal/process/esm_loader').esmLoader;
-// debug('Hooks::register', { urlOrSpecifier, parentURL, data }, moduleLoader.import)
     const keyedExports = await moduleLoader.import(
       urlOrSpecifier,
       parentURL,
       kEmptyObject,
-    ).catch((err) => {
-      writeFileSync(1, `Hooks::register err ${err.stack}\n`);
-      throw err;
-    });
-debug('Hooks::register imported', urlOrSpecifier, keyedExports)
+    );
+
     return this.addCustomLoader(urlOrSpecifier, keyedExports, data);
   }
 
@@ -590,10 +585,8 @@ class HooksProxy {
       AtomicsWait(this.#lock, WORKER_TO_MAIN_THREAD_NOTIFICATION, this.#workerNotificationLastId);
       this.#workerNotificationLastId = AtomicsLoad(this.#lock, WORKER_TO_MAIN_THREAD_NOTIFICATION);
 
-      writeFileSync(1, `HooksProxy::makeSyncRequest: awoken\n`);
       response = this.#worker.receiveMessageSync();
     } while (response == null);
-    writeFileSync(1, `HooksProxy::makeSyncRequest: got response from worker ${JSON.stringify(response)}\n`);
     debug('got sync response from worker', { method, args });
     if (response.message.status === 'never-settle') {
       process.exit(kUnfinishedTopLevelAwait);
@@ -609,7 +602,6 @@ class HooksProxy {
     }
     const { status, body } = response.message;
     if (status === 'error') {
-      writeFileSync(1, `HooksProxy#unwrapMessage: got error from worker ${body}\n`);
       if (body == null || typeof body !== 'object') throw body;
       if (body.serializationFailed || body.serialized == null) {
         throw ERR_WORKER_UNSERIALIZABLE_ERROR();

lib/internal/modules/esm/loader.js

@@ -23,7 +23,7 @@ let defaultResolve, defaultLoad, defaultLoadSync, importMetaInitializer;
 let debug = require('internal/util/debuglog').debuglog('esm', (fn) => {
   debug = fn;
 });
-const { writeFileSync } = require('fs');
+
 
 function newResolveCache() {
   const { ResolveCache } = require('internal/modules/esm/module_map');
@@ -309,16 +309,9 @@ class ModuleLoader {
    * @returns {Promise<ModuleExports>}
    */
   async import(specifier, parentURL, importAssertions) {
-// writeFileSync(1, `ESMLoader::import specifier ${specifier}\n`);
     const moduleJob = await this.getModuleJob(specifier, parentURL, importAssertions);
-// writeFileSync(1, `ESMLoader::import gotModuleJob ${JSON.stringify(moduleJob)}\n`);
-    const { module } = await moduleJob.run().catch((err) => {
-      writeFileSync(1, `ESMLoader::import ${specifier} moduleJob.run caught error ${err.stack}\n`)
-      throw err;
-    });
-writeFileSync(1, `ESMLoader::import ${specifier} gotModuleJob ${JSON.stringify(module)}\n`);
+    const { module } = await moduleJob.run();
     const namespace = module.getNamespace();
-writeFileSync(1, `ESMLoader::import ${specifier} gotModuleJob ${JSON.stringify(namespace)}\n`);
     return namespace;
   }
 

lib/internal/modules/esm/module_job.js

@@ -30,7 +30,6 @@ const resolvedPromise = PromiseResolve();
 let debug = require('internal/util/debuglog').debuglog('esm', (fn) => {
   debug = fn;
 });
-// const { writeFileSync } = require('fs');
 
 const noop = FunctionPrototype;
 
@@ -114,21 +113,20 @@ class ModuleJob {
   }
 
   async _instantiate() {
-    // writeFileSync(1, 'ModuleJob::instantiate()\n');
     const jobsInGraph = new SafeSet();
     const addJobsToDependencyGraph = async (moduleJob) => {
       if (jobsInGraph.has(moduleJob)) {
         return;
       }
       jobsInGraph.add(moduleJob);
-      // writeFileSync(1, 'ModuleJob::instantiate() getting linked jobs\n');
+
       const dependencyJobs = await moduleJob.linked;
-      // writeFileSync(1, 'ModuleJob::instantiate() got linked jobs\n');
+
       return SafePromiseAllReturnVoid(dependencyJobs, addJobsToDependencyGraph);
     };
+
     await addJobsToDependencyGraph(this);
 
-    // writeFileSync(1, 'ModuleJob::instantiate() job added to dep graph\n');
     try {
       if (!hasPausedEntry && this.inspectBrk) {
         hasPausedEntry = true;
@@ -138,7 +136,7 @@ class ModuleJob {
         this.module.instantiate();
       }
     } catch (e) {
-      // writeFileSync(1, `ModuleJob::instantiate() error: ${e.stack}\n`);
+
       decorateErrorStack(e);
       // TODO(@bcoe): Add source map support to exception that occurs as result
       // of missing named export. This is currently not possible because
@@ -218,16 +216,14 @@ class ModuleJob {
   }
 
   async run() {
-    // writeFileSync(1, `ModuleJob::run() instantiating: ${this.url}\n`);
     await this.instantiate();
-    // writeFileSync(1, `ModuleJob::run() instantiated: ${this.url}\n`);
     const timeout = -1;
     const breakOnSigint = false;
+
     try {
       await this.module.evaluate(timeout, breakOnSigint);
-      // writeFileSync(1, `ModuleJob::run() evaluation complete: ${this.module}\n`);
+
     } catch (e) {
-      // writeFileSync(1, `ModuleJob::run() error: ${e.stack}\n`);
       if (e?.name === 'ReferenceError' &&
           isCommonJSGlobalLikeNotDefinedError(e.message)) {
         e.message += ' in ES module scope';
@@ -249,7 +245,7 @@ class ModuleJob {
             'to use the \'.cjs\' file extension.';
         }
       }
-      // writeFileSync(1, `ModuleJob::run() throwing error: ${e.stack}\n`);
+
       throw e;
     }
     return { __proto__: null, module: this.module };

lib/internal/modules/esm/utils.js

@@ -28,7 +28,7 @@ const assert = require('internal/assert');
 let debug = require('internal/util/debuglog').debuglog('esm', (fn) => {
   debug = fn;
 });
-const { writeFileSync } = require('fs');
+
 
 const callbackMap = new SafeWeakMap();
 function setCallbackForWrap(wrap, data) {
@@ -152,10 +152,7 @@ async function initializeHooks() {
     await hooks.register(
       customLoaderURLs[i],
       parentURL,
-    ).catch((err) => {
-      writeFileSync(1, `initializeHooks: Error registering hooks: ${err.stack}\n`);
-      throw err;
-    });
+    );
   }
 debug('initializeHooks finished: hooks', hooks);
 

lib/internal/modules/esm/worker.js

@@ -31,7 +31,6 @@ const {
 } = require('internal/modules/esm/shared_constants');
 const { initializeHooks } = require('internal/modules/esm/utils');
 const { isMarkedAsUntransferable } = require('internal/buffer');
-const { writeFileSync } = require('fs');
 
 
 function transferArrayBuffer(hasError, source) {
@@ -101,13 +100,11 @@ async function customizedModuleWorker(lock, syncCommPort, errorHandler) {
     // be thrown and printed.
     hasInitializationError = true;
     initializationError = exception;
-    writeFileSync(1, `[Worker] Error initializing hooks: ${exception.stack}\n`);
   }
 
   syncCommPort.on('message', handleMessage);
 
   if (hasInitializationError) {
-    writeFileSync(1, `[Worker] posting initialization error: ${initializationError}\n`);
     syncCommPort.postMessage(wrapMessage('error', initializationError));
   } else {
     syncCommPort.postMessage(wrapMessage('success'));