buf: move buffer.slice to runtime deprecation

Signed-off-by: hainenber <[email protected]>

Author: hainenber

doc/api/deprecations.md

@@ -3476,14 +3476,17 @@ const w = new Writable({
 
 <!-- YAML
 changes:
+  - version: v26.0.0
+    pr-url: https://github.com/nodejs/node/pull/60820
+    description: Runtime deprecation.
   - version:
     - v17.5.0
     - v16.15.0
     pr-url: https://github.com/nodejs/node/pull/41596
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only
+Type: Runtime
 
 This method was deprecated because it is not compatible with
 `Uint8Array.prototype.slice()`, which is a superclass of `Buffer`.

lib/buffer.js

@@ -88,6 +88,7 @@ const {
   kIsEncodingSymbol,
   defineLazyProperties,
   encodingsMap,
+  deprecate,
 } = require('internal/util');
 const {
   isAnyArrayBuffer,
@@ -1185,9 +1186,7 @@ Buffer.prototype.subarray = function subarray(start, end) {
   return new FastBuffer(this.buffer, this.byteOffset + start, newLength);
 };
 
-Buffer.prototype.slice = function slice(start, end) {
-  return this.subarray(start, end);
-};
+Buffer.prototype.slice = deprecate(Buffer.prototype.subarray, 'Buffer.prototype.slice is deprecated.', 'DEP0158');
 
 function swap(b, n, m) {
   const i = b[n];

test/parallel/test-buffer-slice-deprecation.js

@@ -0,0 +1,35 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+'use strict';
+
+const common = require('../common');
+
+common.expectWarning('DeprecationWarning',
+                     'Buffer.prototype.slice is deprecated.', 'DEP0158');
+
+const buf = Buffer.from('0123456789', 'utf8');
+buf.slice(-10, 10);
+buf.slice();
+buf.slice('foobar');
+buf.slice(2);
+
+Buffer.alloc(0).slice(0, 1);