tools: add lint rule to keep primordials in ASCII order

PR-URL: #52592
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>

Author: aduh95

lib/.eslintrc.yaml

@@ -185,6 +185,7 @@ rules:
     - groups: [['&&', '||']]
 
   # Custom rules in tools/eslint-rules
+  node-core/alphabetize-primordials: error
   node-core/avoid-prototype-pollution: error
   node-core/lowercase-name-for-primitive: error
   node-core/non-ascii-character: error
@@ -266,3 +267,7 @@ globals:
   module: false
   internalBinding: false
   primordials: false
+overrides:
+  - files: [internal/per_context/primordials.js]
+    rules:
+      node-core/alphabetize-primordials: [error, {enforceTopPosition: false}]

lib/_http_common.js

@@ -23,8 +23,8 @@
 
 const {
   MathMin,
-  Symbol,
   RegExpPrototypeExec,
+  Symbol,
 } = primordials;
 const { setImmediate } = require('timers');
 

lib/_http_outgoing.js

@@ -29,9 +29,9 @@ const {
   NumberPrototypeToString,
   ObjectDefineProperty,
   ObjectKeys,
-  ObjectValues,
   ObjectPrototypeHasOwnProperty,
   ObjectSetPrototypeOf,
+  ObjectValues,
   RegExpPrototypeExec,
   SafeSet,
   StringPrototypeToLowerCase,

lib/_http_server.js

@@ -28,8 +28,8 @@ const {
   MathMin,
   ObjectKeys,
   ObjectSetPrototypeOf,
-  RegExpPrototypeExec,
   ReflectApply,
+  RegExpPrototypeExec,
   Symbol,
   SymbolAsyncDispose,
   SymbolFor,

lib/_tls_common.js

@@ -21,14 +21,14 @@
 
 'use strict';
 
-const tls = require('tls');
-
 const {
   ArrayPrototypePush,
   JSONParse,
   RegExpPrototypeSymbolReplace,
 } = primordials;
 
+const tls = require('tls');
+
 const {
   codes: {
     ERR_TLS_INVALID_PROTOCOL_VERSION,

lib/async_hooks.js

@@ -9,10 +9,10 @@ const {
   FunctionPrototypeBind,
   NumberIsSafeInteger,
   ObjectDefineProperties,
+  ObjectFreeze,
   ObjectIs,
   ReflectApply,
   Symbol,
-  ObjectFreeze,
 } = primordials;
 
 const {

lib/buffer.js

@@ -41,10 +41,10 @@ const {
   StringPrototypeTrim,
   SymbolSpecies,
   SymbolToPrimitive,
+  TypedArrayPrototypeFill,
   TypedArrayPrototypeGetBuffer,
   TypedArrayPrototypeGetByteLength,
   TypedArrayPrototypeGetByteOffset,
-  TypedArrayPrototypeFill,
   TypedArrayPrototypeGetLength,
   TypedArrayPrototypeSet,
   TypedArrayPrototypeSlice,

lib/child_process.js

@@ -28,11 +28,11 @@ const {
   ArrayPrototypeJoin,
   ArrayPrototypeLastIndexOf,
   ArrayPrototypePush,
+  ArrayPrototypePushApply,
   ArrayPrototypeSlice,
   ArrayPrototypeSort,
   ArrayPrototypeSplice,
   ArrayPrototypeUnshift,
-  ArrayPrototypePushApply,
   NumberIsInteger,
   ObjectAssign,
   ObjectDefineProperty,

lib/crypto.js

@@ -25,8 +25,8 @@
 'use strict';
 
 const {
-  ObjectDefineProperty,
   ObjectDefineProperties,
+  ObjectDefineProperty,
 } = primordials;
 
 const {

lib/diagnostics_channel.js

@@ -5,15 +5,15 @@ const {
   ArrayPrototypeIndexOf,
   ArrayPrototypePush,
   ArrayPrototypeSplice,
-  SafeFinalizationRegistry,
   ObjectDefineProperty,
   ObjectGetPrototypeOf,
   ObjectSetPrototypeOf,
   Promise,
   PromisePrototypeThen,
-  PromiseResolve,
   PromiseReject,
+  PromiseResolve,
   ReflectApply,
+  SafeFinalizationRegistry,
   SafeMap,
   SymbolHasInstance,
 } = primordials;