Skip to content

Commit a96cb19

Browse files
committed
deps: make V8 14.2 ABI-compatible with 14.1
- Revert inheritance from `Data` in `DictionaryTemplate` Refs: v8/v8@a6bb35d
1 parent 5f0a257 commit a96cb19

File tree

3 files changed

+1
-10
lines changed

3 files changed

+1
-10
lines changed

deps/v8/include/v8-data.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@ class V8_EXPORT Data {
5252
*/
5353
bool IsFunctionTemplate() const;
5454

55-
/**
56-
* Returns true if this data is a |v8::DictionaryTemplate|.
57-
*/
58-
bool IsDictionaryTemplate() const;
59-
6055
/**
6156
* Returns true if this data is a |v8::Context|.
6257
*/

deps/v8/include/v8-template.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1071,7 +1071,7 @@ class V8_EXPORT ObjectTemplate : public Template {
10711071
/**
10721072
* A template to create dictionary objects at runtime.
10731073
*/
1074-
class V8_EXPORT DictionaryTemplate final : public Data {
1074+
class V8_EXPORT DictionaryTemplate final {
10751075
public:
10761076
/** Creates a new template. Also declares data properties that can be passed
10771077
* on instantiation of the template. Properties can only be declared on

deps/v8/src/api/api.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -847,10 +847,6 @@ bool Data::IsFunctionTemplate() const {
847847
return i::IsFunctionTemplateInfo(*Utils::OpenDirectHandle(this));
848848
}
849849

850-
bool Data::IsDictionaryTemplate() const {
851-
return i::IsDictionaryTemplateInfo(*Utils::OpenDirectHandle(this));
852-
}
853-
854850
bool Data::IsContext() const {
855851
return i::IsContext(*Utils::OpenDirectHandle(this));
856852
}

0 commit comments

Comments
 (0)