Skip to content

Commit a96cf00

Browse files
committed
src: remove v8 namespace prefix
1 parent 914a5ea commit a96cf00

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

src/node_sqlite.cc

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@ using v8::BigInt;
2020
using v8::Boolean;
2121
using v8::Context;
2222
using v8::Exception;
23+
using v8::Function;
2324
using v8::FunctionCallbackInfo;
2425
using v8::FunctionTemplate;
2526
using v8::Integer;
2627
using v8::Isolate;
2728
using v8::Local;
29+
using v8::NewStringType;
2830
using v8::Number;
2931
using v8::Object;
3032
using v8::String;
@@ -237,7 +239,7 @@ void DatabaseSync::CreateSession(const FunctionCallbackInfo<Value>& args) {
237239
Local<Object> options = args[0].As<Object>();
238240

239241
Local<String> table_key =
240-
String::NewFromUtf8(env->isolate(), "table", v8::NewStringType::kNormal)
242+
String::NewFromUtf8(env->isolate(), "table", NewStringType::kNormal)
241243
.ToLocalChecked();
242244
if (options->HasOwnProperty(env->context(), table_key).FromJust()) {
243245
Local<Value> table_value =
@@ -254,7 +256,7 @@ void DatabaseSync::CreateSession(const FunctionCallbackInfo<Value>& args) {
254256
}
255257

256258
Local<String> db_key =
257-
String::NewFromUtf8(env->isolate(), "db", v8::NewStringType::kNormal)
259+
String::NewFromUtf8(env->isolate(), "db", NewStringType::kNormal)
258260
.ToLocalChecked();
259261
if (options->HasOwnProperty(env->context(), db_key).FromJust()) {
260262
Local<Value> db_value =
@@ -330,7 +332,7 @@ void DatabaseSync::ApplyChangeset(const FunctionCallbackInfo<Value>& args) {
330332

331333
Local<String> conflictKey =
332334
String::NewFromUtf8(
333-
env->isolate(), "onConflict", v8::NewStringType::kNormal)
335+
env->isolate(), "onConflict", NewStringType::kNormal)
334336
.ToLocalChecked();
335337
if (options->HasOwnProperty(env->context(), conflictKey).FromJust()) {
336338
Local<Value> conflictValue =
@@ -348,8 +350,7 @@ void DatabaseSync::ApplyChangeset(const FunctionCallbackInfo<Value>& args) {
348350
}
349351

350352
Local<String> filterKey =
351-
String::NewFromUtf8(
352-
env->isolate(), "filter", v8::NewStringType::kNormal)
353+
String::NewFromUtf8(env->isolate(), "filter", NewStringType::kNormal)
353354
.ToLocalChecked();
354355

355356
if (options->HasOwnProperty(env->context(), filterKey).FromJust()) {
@@ -363,12 +364,12 @@ void DatabaseSync::ApplyChangeset(const FunctionCallbackInfo<Value>& args) {
363364
return;
364365
}
365366

366-
Local<v8::Function> filterFunc = filterValue.As<v8::Function>();
367+
Local<Function> filterFunc = filterValue.As<Function>();
367368

368369
filterCallback = [env, filterFunc](std::string item) -> bool {
369370
Local<Value> argv[] = {String::NewFromUtf8(env->isolate(),
370371
item.c_str(),
371-
v8::NewStringType::kNormal)
372+
NewStringType::kNormal)
372373
.ToLocalChecked()};
373374
Local<Value> result =
374375
filterFunc->Call(env->context(), Null(env->isolate()), 1, argv)
@@ -837,7 +838,7 @@ BaseObjectPtr<StatementSync> StatementSync::Create(Environment* env,
837838
}
838839

839840
Session::Session(Environment* env,
840-
v8::Local<v8::Object> object,
841+
Local<Object> object,
841842
BaseObjectWeakPtr<DatabaseSync> database,
842843
sqlite3_session* session)
843844
: BaseObject(env, object),
@@ -888,7 +889,7 @@ Local<FunctionTemplate> Session::GetConstructorTemplate(Environment* env) {
888889
void Session::MemoryInfo(MemoryTracker* tracker) const {}
889890

890891
template <Sqlite3ChangesetGenFunc sqliteChangesetFunc>
891-
void Session::Changeset(const v8::FunctionCallbackInfo<v8::Value>& args) {
892+
void Session::Changeset(const FunctionCallbackInfo<Value>& args) {
892893
Session* session;
893894
ASSIGN_OR_RETURN_UNWRAP(&session, args.This());
894895
Environment* env = Environment::GetCurrent(args);
@@ -902,11 +903,9 @@ void Session::Changeset(const v8::FunctionCallbackInfo<v8::Value>& args) {
902903

903904
auto freeChangeset = OnScopeLeave([&] { sqlite3_free(pChangeset); });
904905

905-
v8::Local<v8::ArrayBuffer> buffer =
906-
v8::ArrayBuffer::New(env->isolate(), nChangeset);
906+
Local<ArrayBuffer> buffer = ArrayBuffer::New(env->isolate(), nChangeset);
907907
std::memcpy(buffer->GetBackingStore()->Data(), pChangeset, nChangeset);
908-
v8::Local<v8::Uint8Array> uint8Array =
909-
v8::Uint8Array::New(buffer, 0, nChangeset);
908+
Local<Uint8Array> uint8Array = Uint8Array::New(buffer, 0, nChangeset);
910909

911910
args.GetReturnValue().Set(uint8Array);
912911
}

0 commit comments

Comments
 (0)