Skip to content

Commit ad03400

Browse files
committed
deps: V8: cherry-pick 87356585659b
Original commit message: [flags] Ignore memory tuning flags when computing hash for code caching Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Joyee Cheung <[email protected]> Cr-Commit-Position: refs/heads/main@{#102443} Refs: v8/v8@8735658
1 parent f0aa073 commit ad03400

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.7',
41+
'v8_embedder_string': '-node.8',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/flags/flags.cc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -477,6 +477,15 @@ uint32_t ComputeFlagListHash() {
477477
if (flag.PointsTo(&v8_flags.random_seed)) continue;
478478
if (flag.PointsTo(&v8_flags.predictable)) continue;
479479

480+
// These flags are not relevant for code caching and are often set by
481+
// embedders to tune memory usage.
482+
if (flag.PointsTo(&v8_flags.max_old_space_size) ||
483+
flag.PointsTo(&v8_flags.min_semi_space_size) ||
484+
flag.PointsTo(&v8_flags.max_semi_space_size) ||
485+
flag.PointsTo(&v8_flags.max_heap_size)) {
486+
continue;
487+
}
488+
480489
// The following flags are implied by --predictable (some negated).
481490
if (flag.PointsTo(&v8_flags.concurrent_sparkplug) ||
482491
flag.PointsTo(&v8_flags.concurrent_recompilation) ||

0 commit comments

Comments
 (0)