fixup! module: handle null source from async loader hooks in sync hooks

Author: joyeecheung

lib/internal/modules/cjs/loader.js

@@ -1794,9 +1794,7 @@ function loadSource(mod, filename, formatFromNode) {
 
   const defaultLoad = getDefaultLoad(mod[kURL], filename);
   const loadResult = loadWithHooks(mod[kURL], mod[kFormat], /* importAttributes */ undefined,
-                                   getCjsConditionsArray(),
-                                   defaultLoad,
-                                   validateLoadStrict);
+                                   getCjsConditionsArray(), defaultLoad, validateLoadStrict);
   // Reset the module properties with load hook results.
   if (loadResult.format !== undefined) {
     mod[kFormat] = loadResult.format;

lib/internal/modules/customization_hooks.js

@@ -275,7 +275,7 @@ function validateLoadStrict(url, context, result) {
 }
 
 function validateLoadSloppy(url, context, result) {
-  validateSourceSloppy(url, context, result);
+  validateSourcePermissive(url, context, result);
   validateFormat(url, context, result);
   return result;
 }
@@ -299,11 +299,12 @@ function validateSourceStrict(url, context, result) {
   }
 }
 
-function validateSourceSloppy(url, context, result) {
+function validateSourcePermissive(url, context, result) {
   const { source, format } = result;
   if (format === 'commonjs' && source == null) {
     // Accommodate the quirk in defaultLoad used by asynchronous loader hooks
     // which sets source to null for commonjs.
+    // See: https://github.com/nodejs/node/issues/57327#issuecomment-2701382020
     return;
   }
   validateSourceStrict(url, context, result);

lib/internal/modules/esm/translators.js

@@ -344,7 +344,7 @@ translators.set('commonjs', function commonjsStrategy(url, translateContext, par
   }
 
   // For backward-compatibility, it's possible to return a nullish value for
-  // CJS source associated with a file: URL - that usually means the source is not
+  // CJS source associated with a `file:` URL - that usually means the source is not
   // customized (is loaded by default load) or the hook author wants it to be reloaded
   // through CJS routine. In this case, the source is obtained by calling the
   // monkey-patchable CJS loader.

test/common/tmpdir.js

@@ -38,7 +38,7 @@ const testRoot = process.env.NODE_TEST_DIR ?
 // Using a `.` prefixed name, which is the convention for "hidden" on POSIX,
 // gets tools to ignore it by default or by simple rules, especially eslint.
 const tmpdirName = '.tmp.' +
-  (process.env.TEST_SERIAL_ID || process.env.TEST_THREAD_ID || '0');
+(process.env.TEST_SERIAL_ID || process.env.TEST_THREAD_ID || '0');
 let tmpPath = path.join(testRoot, tmpdirName);
 
 let firstRefresh = true;

test/parallel/test-single-executable-blob-config-errors.js

@@ -105,7 +105,7 @@ const { spawnSyncAndAssert } = require('../common/child_process');
       cwd: tmpdir.path,
     }, {
       status: 1,
-      stderr: /"disableExperimentalSEAWarning" field of .*invalid-disableExperimentalSEAWarning\.json is not a Boolean/
+      stderr: /"disableExperimentalSEAWarning" field of .*invalid-disableExperimentalSEAWarning\UN.json is not a Boolean/
     });
 }