build: build v8 with -fvisibility=hidden on macOS

joyeecheung · joyeecheung · commit b8c972d12d43 · 2024-12-16T22:43:17.000+01:00
V8 should be built with -fvisibility=hidden, otherwise
the resulting binary would contain unnecessary symbols. In
particular, on macOS, this leads to 5000+ weak symbols
resolved at runtime, leading to a startup regression.
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
@@ -42,6 +42,9 @@
       }
     },
   },
+  'xcode_settings': {
+    'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',  # -fvisibility=hidden
+  },
   'targets': [
     {
       'target_name': 'v8_pch',

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,9 @@`
`42`	`42`	`}`
`43`	`43`	`},`
`44`	`44`	`},`
	`45`	`+ 'xcode_settings': {`
	`46`	`+ 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden`
	`47`	`+ },`
`45`	`48`	`'targets': [`
`46`	`49`	`{`
`47`	`50`	`'target_name': 'v8_pch',`