fixup! tools: add lint rule to ensure assertions are reached

Author: aduh95

test/node-api/test_threadsafe_function/test.js

@@ -79,7 +79,7 @@ function testUnref(queueSize) {
 
 new Promise(function testWithoutJSMarshaller(resolve) {
   let callCount = 0;
-  binding.StartThreadNoNative(function testCallback() {
+  binding.StartThreadNoNative(common.mustCallAtLeast(function testCallback() {
     callCount++;
 
     // The default call-into-JS implementation passes no arguments.
@@ -91,7 +91,7 @@ new Promise(function testWithoutJSMarshaller(resolve) {
         }, false);
       });
     }
-  }, false /* abort */, false /* launchSecondary */, binding.MAX_QUEUE_SIZE);
+  }), false /* abort */, false /* launchSecondary */, binding.MAX_QUEUE_SIZE);
 })
 
 // Start the thread in blocking mode, and assert that all values are passed.

test/pummel/test-child-process-spawn-loop.js

@@ -52,7 +52,7 @@ const doSpawn = common.mustCall((i) => {
       finished = true;
     }
   }));
-}, N);
+}, N + 1);
 
 doSpawn(0);
 

test/pummel/test-fs-watch-file-slow.js

@@ -55,7 +55,7 @@ fs.watchFile(FILENAME, { interval: TIMEOUT - 250 }, common.mustCall((curr, prev)
     default:
       assert(0);
   }
-}));
+}, 4));
 
 process.on('exit', function() {
   assert.strictEqual(nevents, 4);

test/pummel/test-fs-watch-non-recursive.js

@@ -39,11 +39,11 @@ const filepath = path.join(testsubdir, 'watch.txt');
 fs.mkdirSync(testsubdir, 0o700);
 
 const doWatch = common.mustCall(() => {
-  const watcher = fs.watch(testDir, { persistent: true }, common.mustCall((event, filename) => {
+  const watcher = fs.watch(testDir, { persistent: true }, common.mustCallAtLeast((event, filename) => {
     // This function may be called with the directory depending on timing but
     // must not be called with the file..
     assert.strictEqual(filename, 'testsubdir');
-  }));
+  }, 0));
   setTimeout(() => {
     fs.writeFileSync(filepath, 'test');
   }, 100);

test/pummel/test-http-many-keep-alive-connections.js

@@ -34,7 +34,7 @@ const server = http.Server(common.mustCall((req, res) => {
   assert.strictEqual(req.connection, connection);
   res.writeHead(200);
   res.end('hello world\n');
-}));
+}, expected));
 
 server.once('connection', function(c) {
   connection = c;

test/pummel/test-net-many-clients.js

@@ -62,7 +62,7 @@ function runClient(port, callback) {
     client.end();
   });
 
-  client.on('close', common.mustCall((had_error) => {
+  client.on('close', common.mustCall(function(had_error) {
     assert.strictEqual(had_error, false);
     assert.strictEqual(client.recved.length, bytes);
 

test/pummel/test-tls-server-large-request.js

@@ -39,7 +39,7 @@ const options = {
 class Mediator extends stream.Writable {
   buf = '';
 
-  _write = common.mustCall((data, enc, cb) => {
+  _write = common.mustCallAtLeast((data, enc, cb) => {
     this.buf += data;
     setTimeout(cb, 0);