optimize HandleScope usage in heap_utils loops

Author: mertcanaltin

src/heap_utils.cc

@@ -117,10 +117,8 @@ class JSGraph : public EmbedderGraph {
     Local<String> wraps_string = FIXED_ONE_BYTE_STRING(isolate_, "wraps");
     Local<String> to_string = FIXED_ONE_BYTE_STRING(isolate_, "to");
 
-    for (const std::unique_ptr<Node>& n : nodes_) {
-      HandleScope handle_scope(isolate_);
+    for (const std::unique_ptr<Node>& n : nodes_)
       info_objects[n.get()] = Object::New(isolate_);
-    }
 
     {
       HandleScope handle_scope(isolate_);
@@ -171,34 +169,36 @@ class JSGraph : public EmbedderGraph {
         return MaybeLocal<Array>();
     }
 
-    for (const auto& edge_info : edges_) {
-      Node* source = edge_info.first;
-      Local<Value> edges;
-      if (!info_objects[source]->Get(context, edges_string).ToLocal(&edges) ||
-          !edges->IsArray()) {
-        return MaybeLocal<Array>();
-      }
+    {
+      HandleScope handle_scope(isolate_);
+      for (const auto& edge_info : edges_) {
+        Node* source = edge_info.first;
+        Local<Value> edges;
+        if (!info_objects[source]->Get(context, edges_string).ToLocal(&edges) ||
+            !edges->IsArray()) {
+          return MaybeLocal<Array>();
+        }
 
-      size_t i = 0;
-      size_t j = 0;
-      for (const auto& edge : edge_info.second) {
-        HandleScope handle_scope(isolate_);
-        Local<Object> to_object = info_objects[edge.second];
-        Local<Object> edge_obj = Object::New(isolate_);
-        Local<Value> edge_name_value;
-        const char* edge_name = edge.first;
-        if (edge_name != nullptr) {
-          if (!String::NewFromUtf8(isolate_, edge_name)
-              .ToLocal(&edge_name_value)) {
+        size_t i = 0;
+        size_t j = 0;
+        for (const auto& edge : edge_info.second) {
+          Local<Object> to_object = info_objects[edge.second];
+          Local<Object> edge_obj = Object::New(isolate_);
+          Local<Value> edge_name_value;
+          const char* edge_name = edge.first;
+          if (edge_name != nullptr) {
+            if (!String::NewFromUtf8(isolate_, edge_name)
+                .ToLocal(&edge_name_value)) {
+              return MaybeLocal<Array>();
+            }
+          } else {
+            edge_name_value = Number::New(isolate_, static_cast<double>(j++));
+          }
+          if (edge_obj->Set(context, name_string, edge_name_value).IsNothing() ||
+              edge_obj->Set(context, to_string, to_object).IsNothing() ||
+              edges.As<Array>()->Set(context, i++, edge_obj).IsNothing()) {
             return MaybeLocal<Array>();
           }
-        } else {
-          edge_name_value = Number::New(isolate_, static_cast<double>(j++));
-        }
-        if (edge_obj->Set(context, name_string, edge_name_value).IsNothing() ||
-            edge_obj->Set(context, to_string, to_object).IsNothing() ||
-            edges.As<Array>()->Set(context, i++, edge_obj).IsNothing()) {
-          return MaybeLocal<Array>();
         }
       }
     }