File tree Expand file tree Collapse file tree 1 file changed +11
-0
lines changed
doc/contributing/maintaining Expand file tree Collapse file tree 1 file changed +11
-0
lines changed Original file line number Diff line number Diff line change @@ -126,6 +126,17 @@ can be added by:
126126 paste one of the existing entries and then update to match the
127127 import name for the dependency and the #define generated.
128128
129+ * if the version of the dependency is reported in ` process.versions ` ,
130+ update ` src/node_metadata.h ` and ` src/node_metadata.cc ` so that the
131+ version is not reported when the dependency is externalized.
132+ Not reporting the version is better than incorrectly reporting
133+ the version of the dependency bundled with Node.js, instead of the
134+ version for the externalized dependency. Use one of the existing
135+ externalized dependencies, like Undici, as an example of how to
136+ update these files correctly. Make sure to run the tests with the
137+ dependency externalized, as the tests will also need to be updated
138+ to handle this properly.
139+
129140## Supporting non-externalized dependencies with JavaScript code
130141
131142If the dependency consists of JavaScript in the
You can’t perform that action at this time.
0 commit comments