util: reduce TextEncoder.encodeInto function size

Author: anonrig

lib/internal/encoding.js

@@ -61,11 +61,6 @@ const {
 
 const { Buffer } = require('buffer');
 
-function validateEncoder(obj) {
-  if (obj == null || obj[kEncoder] !== true)
-    throw new ERR_INVALID_THIS('TextEncoder');
-}
-
 function validateDecoder(obj) {
   if (obj == null || obj[kDecoder] !== true)
     throw new ERR_INVALID_THIS('TextDecoder');
@@ -338,45 +333,50 @@ function getEncodingFromLabel(label) {
   return encodings.get(trimAsciiWhitespace(label.toLowerCase()));
 }
 
+let lazyInspect;
+
 class TextEncoder {
-  constructor() {
-    this[kEncoder] = true;
+  #encoding = 'utf-8';
+
+  #encode(input) {
+    return encodeUtf8String(`${input}`);
+  }
+
+  #encodeInto(input, dest) {
+    encodeInto(src, dest);
+    // We need to read from the binding here since the buffer gets refreshed
+    // from the snapshot.
+    const { 0: read, 1: written } = encodeIntoResults;
+    return { read, written };
   }
 
   get encoding() {
-    validateEncoder(this);
-    return 'utf-8';
+    return this.#encoding;
   }
 
   encode(input = '') {
-    validateEncoder(this);
-    return encodeUtf8String(`${input}`);
+    return this.#encode(input);
   }
 
   encodeInto(src, dest) {
-    validateEncoder(this);
     validateString(src, 'src');
     if (!dest || !isUint8Array(dest))
       throw new ERR_INVALID_ARG_TYPE('dest', 'Uint8Array', dest);
 
-    encodeInto(src, dest);
-    // We need to read from the binding here since the buffer gets refreshed
-    // from the snapshot.
-    const { 0: read, 1: written } = encodeIntoResults;
-    return { read, written };
+    return this.#encodeInto(src, dest);
   }
 
   [inspect](depth, opts) {
-    validateEncoder(this);
     if (typeof depth === 'number' && depth < 0)
       return this;
     const ctor = getConstructorOf(this);
     const obj = { __proto__: {
       constructor: ctor === null ? TextEncoder : ctor,
     } };
-    obj.encoding = this.encoding;
+    obj.encoding = this.#encoding;
     // Lazy to avoid circular dependency
-    return require('internal/util/inspect').inspect(obj, opts);
+    lazyInspect ??= require('internal/util/inspect').inspect;
+    return lazyInspect(obj, opts);
   }
 }