repl: catch promise errors during eval in completion

Fixes: #58903

Author: islandryu

lib/repl.js

@@ -98,6 +98,7 @@ const {
 
 const {
   isProxy,
+  isPromise,
 } = require('internal/util/types');
 
 const { BuiltinModule } = require('internal/bootstrap/realm');
@@ -1560,6 +1561,10 @@ function complete(line, callback) {
         const evalExpr = `try { ${expr} } catch {}`;
         this.eval(evalExpr, this.context, getREPLResourceName(), (e, obj) => {
           try {
+            if (isPromise(obj)) {
+              obj.catch(() => {});
+            }
+
             let p;
             if ((typeof obj === 'object' && obj !== null) ||
               typeof obj === 'function') {
@@ -1759,6 +1764,7 @@ function findExpressionCompleteTarget(code) {
  * @returns {void}
  */
 function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {
+
   if (expr?.type !== 'MemberExpression') {
     // If the expression is not a member one for obvious reasons no getters are involved
     return callback(false);
@@ -1796,6 +1802,9 @@ function includesProxiesOrGetters(expr, exprStr, evalFn, ctx, callback) {
   // is the property identifier/literal)
   if (expr.object.type === 'Identifier') {
     return evalFn(`try { ${expr.object.name} } catch {}`, ctx, getREPLResourceName(), (err, obj) => {
+      if (isPromise(obj)) {
+        obj.catch(() => {});
+      }
       if (err) {
         return callback(false);
       }

test/parallel/test-repl-tab-complete-promises.js

@@ -0,0 +1,47 @@
+'use strict';
+
+const common = require('../common');
+const repl = require('repl');
+const ArrayStream = require('../common/arraystream');
+const assert = require('assert');
+
+const completionTests = [
+  { send: 'Promise.reject().' },
+  { send: 'let p = Promise.reject().' },
+  { send: 'Promise.resolve().' },
+  { send: 'Promise.resolve().then(() => {}).' },
+  { send: `async function f() {throw new Error('test');}; f().` },
+  { send: `async function f() {}; f().` },
+];
+
+(async function() {
+  await runReplCompleteTests(completionTests);
+})().then(common.mustCall());
+
+async function runReplCompleteTests(tests) {
+  const input = new ArrayStream();
+  const output = new ArrayStream();
+
+  const replServer = repl.start({
+    prompt: '',
+    input,
+    output: output,
+    allowBlockingCompletions: true,
+    terminal: true
+  });
+
+  replServer._domain.on('error', (e) => {
+    assert.fail(`Error in REPL domain: ${e}`);
+  });
+  for (const { send } of tests) {
+    replServer.complete(
+      send,
+      common.mustCall((error, data) => {
+        assert.strictEqual(error, null);
+        assert.strictEqual(data.length, 2);
+        assert.strictEqual(typeof data[1], 'string');
+        assert.ok(send.includes(data[1]));
+      })
+    );
+  }
+}