lib: refactor slice usage to subarray

Signed-off-by: hainenber <[email protected]>

Author: hainenber

lib/_http_server.js

@@ -1072,7 +1072,7 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
     if (server.listenerCount(eventName) > 0) {
       debug('SERVER have listener for %s', eventName);
 
-      const bodyHead = d.slice(ret, d.length);
+      const bodyHead = d.subarray(ret, d.length);
 
       if (req.complete && socket[kUpgradeStream]) {
         // Previously emitted, now completed - just activate the stream

lib/internal/streams/readable.js

@@ -1620,9 +1620,8 @@ function fromList(n, state) {
       }
     }
   } else if (n < buf[idx].length) {
-    // `slice` is the same for buffers and strings.
-    ret = buf[idx].slice(0, n);
-    buf[idx] = buf[idx].slice(n);
+    ret = typeof buf[idx] === 'string' ? buf[idx].slice(0, n) : buf[idx].subarray(0, n);
+    buf[idx] = typeof buf[idx] === 'string' ? buf[idx].slice(n) : buf[idx].subarray(n);
   } else if (n === buf[idx].length) {
     // First chunk is a perfect match.
     ret = buf[idx];

lib/internal/test_runner/runner.js

@@ -330,7 +330,7 @@ class FileTest extends Test {
     while (bufferHead && headerIndex !== 0) {
       const nonSerializedData = headerIndex === -1 ?
         bufferHead :
-        bufferHead.slice(0, headerIndex);
+        bufferHead.subarray(0, headerIndex);
       nonSerialized = Buffer.concat([nonSerialized, nonSerializedData]);
       this.#rawBufferSize -= TypedArrayPrototypeGetLength(nonSerializedData);
       if (headerIndex === -1) {

lib/zlib.js

@@ -440,7 +440,7 @@ function processChunkSync(self, chunk, flushFlag) {
 
     const have = availOutBefore - availOutAfter;
     if (have > 0) {
-      const out = buffer.slice(offset, offset + have);
+      const out = buffer.subarray(offset, offset + have);
       offset += have;
       buffers.push(out);
       nread += out.byteLength;
@@ -525,7 +525,7 @@ function processCallback() {
   const have = handle.availOutBefore - availOutAfter;
   let streamBufferIsFull = false;
   if (have > 0) {
-    const out = self._outBuffer.slice(self._outOffset, self._outOffset + have);
+    const out = self._outBuffer.subarray(self._outOffset, self._outOffset + have);
     self._outOffset += have;
     streamBufferIsFull = !self.push(out);
   } else {

test/parallel/test-buffer-nopendingdep-map.js

@@ -10,4 +10,4 @@ process.on('warning', common.mustNotCall('A warning should not be emitted'));
 
 Buffer.from('abc').map((i) => i);
 Buffer.from('abc').filter((i) => i);
-Buffer.from('abc').slice(1, 2);
+Buffer.from('abc').subarray(1, 2);

test/parallel/test-zlib.js

@@ -140,7 +140,7 @@ class SlowStream extends stream.Stream {
         return this.emit('end');
       }
       const end = Math.min(this.offset + this.trickle, this.length);
-      const c = this.chunk.slice(this.offset, end);
+      const c = this.chunk.subarray(this.offset, end);
       this.offset += c.length;
       this.emit('data', c);
       process.nextTick(emit);