Skip to content

Commit cc6263a

Browse files
committed
test,sqlite: test async classes
1 parent 7acd4eb commit cc6263a

File tree

3 files changed

+970
-55
lines changed

3 files changed

+970
-55
lines changed

src/node_sqlite.cc

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2640,17 +2640,21 @@ MaybeLocal<Promise::Resolver> StatementAsyncExecutionHelper::Get(
26402640
return;
26412641
}
26422642

2643+
TryCatch try_catch(isolate);
26432644
Local<Value> result;
2644-
if (!StatementSQLiteToJSConverter::ConvertStatementGet(env,
2645-
stmt->statement_,
2646-
num_cols,
2647-
db->use_big_ints(),
2648-
stmt->return_arrays_)
2649-
.ToLocal(&result)) {
2645+
if (StatementSQLiteToJSConverter::ConvertStatementGet(env,
2646+
stmt->statement_,
2647+
num_cols,
2648+
stmt->use_big_ints_,
2649+
stmt->return_arrays_)
2650+
.ToLocal(&result)) {
2651+
resolver->Resolve(env->context(), result).FromJust();
26502652
return;
26512653
}
26522654

2653-
resolver->Resolve(env->context(), result).FromJust();
2655+
if (try_catch.HasCaught()) {
2656+
resolver->Reject(env->context(), try_catch.Exception()).FromJust();
2657+
}
26542658
};
26552659

26562660
Local<Promise::Resolver> resolver =

0 commit comments

Comments
 (0)