src: apply joyee's suggestion

Author: CGQAQ

src/node.cc

@@ -1422,11 +1422,6 @@ bool LoadSnapshotData(const SnapshotData** snapshot_data_ptr) {
 }
 
 static ExitCode StartInternal(int argc, char** argv) {
-  CHECK_GT(argc, 0);
-
-  // Hack around with the argv pointer. Used for process.title = "blah".
-  argv = uv_setup_args(argc, argv);
-
   std::shared_ptr<InitializationResultImpl> result =
       InitializeOncePerProcessInternal(
           std::vector<std::string>(argv, argv + argc));
@@ -1485,8 +1480,22 @@ static ExitCode StartInternal(int argc, char** argv) {
 }
 
 int Start(int argc, char** argv) {
+  CHECK_GT(argc, 0);
+
+  // Hack around with the argv pointer. Used for process.title = "blah".
+  argv = uv_setup_args(argc, argv);
+
 #ifndef DISABLE_SINGLE_EXECUTABLE_APPLICATION
-  std::tie(argc, argv) = sea::FixupArgsForSEA(argc, argv);
+  char** new_argv = nullptr;
+  std::tie(argc, new_argv) = sea::FixupArgsForSEA(argc, argv);
+
+#ifdef _WIN32
+  if (new_argv != argv) {
+    delete[] argv;
+  }
+#endif
+
+  argv = new_argv;
 #endif
   return static_cast<int>(StartInternal(argc, argv));
 }

src/node_sea.cc

@@ -271,9 +271,6 @@ std::tuple<int, char**> FixupArgsForSEA(int argc, char** argv) {
     new_argv.emplace_back(argv[0]);
     new_argv.insert(new_argv.end(), argv, argv + argc);
     new_argv.emplace_back(nullptr);
-#ifdef _WIN32
-    delete[] argv;
-#endif
     argc = new_argv.size() - 1;
     argv = new_argv.data();
   }