tools: add eslint rule prefer-assert-methods

PR-URL: #8622
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yorkie Liu <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>

Author: danyshaanan

test/.eslintrc

@@ -3,3 +3,4 @@
 rules:
   ## common module is mandatory in tests
   required-modules: [2, common]
+  prefer-assert-methods: 2

test/addons/load-long-path/test.js

@@ -30,5 +30,5 @@ fs.writeFileSync(addonDestinationPath, contents);
 
 // Attempt to load at long path destination
 var addon = require(addonDestinationPath);
-assert(addon != null);
-assert(addon.hello() == 'world');
+assert.notEqual(addon, null);
+assert.equal(addon.hello(), 'world');

test/gc/test-http-client-connaborted.js

@@ -64,7 +64,7 @@ function status() {
   console.log('Collected: %d/%d', countGC, count);
   if (done === todo) {
     console.log('All should be collected now.');
-    assert(count === countGC);
+    assert.strictEqual(count, countGC);
     process.exit(0);
   }
 }

test/gc/test-http-client-timeout.js

@@ -73,8 +73,7 @@ function status() {
   console.log('Collected: %d/%d', countGC, count);
   if (done === todo) {
     console.log('All should be collected now.');
-    assert(count === countGC);
+    assert.strictEqual(count, countGC);
     process.exit(0);
   }
 }
-

test/gc/test-http-client.js

@@ -62,8 +62,7 @@ function status() {
   console.log('Collected: %d/%d', countGC, count);
   if (done === todo) {
     console.log('All should be collected now.');
-    assert(count === countGC);
+    assert.strictEqual(count, countGC);
     process.exit(0);
   }
 }
-

test/gc/test-net-timeout.js

@@ -69,7 +69,7 @@ function status() {
       global.gc();
       console.log('All should be collected now.');
       console.log('Collected: %d/%d', countGC, count);
-      assert(count === countGC);
+      assert.strictEqual(count, countGC);
       process.exit(0);
     }, 200);
   }

test/parallel/test-child-process-detached.js

@@ -23,4 +23,3 @@ process.on('exit', function() {
     process.kill(persistentPid);
   });
 });
-

test/parallel/test-child-process-fork-regr-gh-2847.js

@@ -45,7 +45,7 @@ var server = net.createServer(function(s) {
 
   worker.process.once('close', common.mustCall(function() {
     // Otherwise the crash on `_channel.fd` access may happen
-    assert(worker.process._channel === null);
+    assert.strictEqual(worker.process._channel, null);
     server.close();
   }));
 

test/parallel/test-cluster-setup-master-argv.js

@@ -12,7 +12,7 @@ cluster.on('setup', function() {
                realArgs[realArgs.length - 1]);
 });
 
-assert(process.argv[process.argv.length - 1] !== 'OMG,OMG');
+assert.notStrictEqual(process.argv[process.argv.length - 1], 'OMG,OMG');
 process.argv.push('OMG,OMG');
 process.argv.push('OMG,OMG');
 cluster.setupMaster();

test/parallel/test-domain-http-server.js

@@ -30,7 +30,7 @@ var server = http.createServer(function(req, res) {
     var data = JSON.stringify(objects[req.url.replace(/[^a-z]/g, '')]);
 
     // this line will throw if you pick an unknown key
-    assert(data !== undefined, 'Data should not be undefined');
+    assert.notStrictEqual(data, undefined, 'Data should not be undefined');
 
     res.writeHead(200);
     res.end(data);