Skip to content

Commit dbfc919

Browse files
committed
fix: undici as shared-library should pass test-inspector-network-websocket.js test
1 parent 5b32bb1 commit dbfc919

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

test/parallel/test-inspector-network-websocket.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,20 @@ const WebSocketServer = require('../common/websocket-server');
1111
const inspector = require('node:inspector/promises');
1212
const dc = require('diagnostics_channel');
1313

14+
const nameRE = 'undici' in process.versions
15+
? /^node:internal\/deps\/undici\/undici$/u
16+
: /undici/u;
17+
1418
const session = new inspector.Session();
1519
session.connect();
1620

1721
dc.channel('undici:websocket:socket_error').subscribe((message) => {
1822
console.error('WebSocket error:', message);
1923
});
2024

21-
function findFrameInInitiator(scriptName, initiator) {
25+
function findFrameInInitiator(regex, initiator) {
2226
const frame = initiator.stack.callFrames.find((it) => {
23-
return it.url === scriptName;
27+
return regex.test(it.url);
2428
});
2529
return frame;
2630
}
@@ -39,7 +43,7 @@ async function test() {
3943
assert.ok(message.params.requestId);
4044
assert.strictEqual(typeof message.params.initiator, 'object');
4145
assert.strictEqual(message.params.initiator.type, 'script');
42-
assert.ok(findFrameInInitiator('node:internal/deps/undici/undici', message.params.initiator));
46+
assert.ok(findFrameInInitiator(nameRE, message.params.initiator));
4347
requestId = message.params.requestId;
4448
}));
4549

0 commit comments

Comments
 (0)