lib,src,test: fix tests without SQLite

Author: aduh95

.github/workflows/test-shared.yml

@@ -164,7 +164,7 @@ jobs:
             --arg ccache '(import <nixpkgs> {}).sccache' \
             --arg devTools '[]' \
             --arg benchmarkTools '[]' \
-            ${{ endsWith(matrix.system, '-darwin') && '--arg extraConfigFlags ''["--without-inspector"]'' \' || '\' }}
+            ${{ endsWith(matrix.system, '-darwin') && '--arg extraConfigFlags ''["--without-inspector"]'' --arg withSQLite false \' || '\' }}
             --run '
                 make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9 --skip-tests=$CI_SKIP_TESTS"
             '

lib/internal/process/pre_execution.js

@@ -398,6 +398,7 @@ function setupQuic() {
 
 function setupWebStorage() {
   if (getEmbedderOptions().noBrowserGlobals ||
+      !getEmbedderOptions().hasSQLite ||
       !getOptionValue('--experimental-webstorage')) {
     return;
   }

src/node_config.cc

@@ -90,6 +90,12 @@ static void InitConfig(Local<Object> target,
   READONLY_FALSE_PROPERTY(target, "hasInspector");
 #endif
 
+#if HAVE_SQLITE
+  READONLY_TRUE_PROPERTY(target, "hasSQLite");
+#else
+  READONLY_FALSE_PROPERTY(target, "hasSQLite");
+#endif
+
 // configure --no-browser-globals
 #ifdef NODE_NO_BROWSER_GLOBALS
   READONLY_TRUE_PROPERTY(target, "noBrowserGlobals");

test/common/index.js

@@ -370,7 +370,6 @@ const knownGlobals = new Set([
  'CompressionStream',
  'DecompressionStream',
  'Storage',
- 'sessionStorage',
 ].forEach((i) => {
   if (globalThis[i] !== undefined) {
     knownGlobals.add(globalThis[i]);
@@ -387,6 +386,9 @@ if (hasCrypto) {
 if (hasLocalStorage) {
   knownGlobals.add(globalThis.localStorage);
 }
+if (hasSQLite) {
+  knownGlobals.add(globalThis.sessionStorage);
+}
 
 const { Worker } = require('node:worker_threads');
 knownGlobals.add(Worker);

test/parallel/test-webstorage-without-sqlite.js

@@ -0,0 +1,8 @@
+'use strict';
+
+const { hasSQLite } = require('../common');
+const assert = require('node:assert');
+
+// Ensuring that `sessionStorage` is not a getter that throws when built without SQLite.
+assert.strictEqual(typeof sessionStorage, hasSQLite ? 'object' : 'undefined');
+assert.strictEqual(Object.hasOwn(globalThis, 'sessionStorage'), hasSQLite);

typings/internalBinding/config.d.ts

@@ -8,6 +8,7 @@ export interface ConfigBinding {
   hasTracing: boolean;
   hasNodeOptions: boolean;
   hasInspector: boolean;
+  hasSQLite: boolean;
   noBrowserGlobals: boolean;
   bits: number;
   getDefaultLocale(): string;