test: add missing newlines to repl .exit writes

some tests write `.exit` into a repl server without
including a newline character (`\n`), such commands
are therefore simply not executed at all, the changes
here add the missing newlines and as a side effect
remove no longer necessary `end` calls

PR-URL: #58041
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>

Author: dario-piotrowicz

test/parallel/test-repl-function-definition-edge-case.js

@@ -1,6 +1,6 @@
 // Reference: https://github.com/nodejs/node/pull/7624
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const repl = require('repl');
 const stream = require('stream');
@@ -9,7 +9,8 @@ const r = initRepl();
 
 r.input.emit('data', 'function a() { return 42; } (1)\n');
 r.input.emit('data', 'a\n');
-r.input.emit('data', '.exit');
+r.input.emit('data', '.exit\n');
+r.once('exit', common.mustCall());
 
 const expected = '1\n[Function: a]\n';
 const got = r.output.accumulator.join('');

test/parallel/test-repl-import-referrer.js

@@ -8,24 +8,19 @@ const args = ['--interactive'];
 const opts = { cwd: fixtures.path('es-modules') };
 const child = cp.spawn(process.execPath, args, opts);
 
-const outputs = [];
+let output = '';
 child.stdout.setEncoding('utf8');
 child.stdout.on('data', (data) => {
-  outputs.push(data);
-  if (outputs.length === 3) {
-    // All the expected outputs have been received
-    // so we can close the child process's stdin
-    child.stdin.end();
-  }
+  output += data;
 });
 
 child.on('exit', common.mustCall(() => {
-  const results = outputs[2].split('\n')[0];
-  assert.strictEqual(
+  const results = output.replace(/^> /mg, '').split('\n').slice(2);
+  assert.deepStrictEqual(
     results,
-    '[Module: null prototype] { message: \'A message\' }'
+    ['[Module: null prototype] { message: \'A message\' }', '']
   );
 }));
 
 child.stdin.write('await import(\'./message.mjs\');\n');
-child.stdin.write('.exit');
+child.stdin.write('.exit\n');

test/parallel/test-repl-options.js

@@ -136,6 +136,5 @@ r4.close();
   child.stdin.write(
     'assert.ok(util.inspect(repl.repl, {depth: -1}).includes("REPLServer"));\n'
   );
-  child.stdin.write('.exit');
-  child.stdin.end();
+  child.stdin.write('.exit\n');
 }

test/parallel/test-repl-require-context.js

@@ -20,5 +20,4 @@ child.on('exit', common.mustCall(() => {
 child.stdin.write('const isObject = (obj) => obj.constructor === Object;\n');
 child.stdin.write('isObject({});\n');
 child.stdin.write(`require(${JSON.stringify(fixture)}).isObject({});\n`);
-child.stdin.write('.exit');
-child.stdin.end();
+child.stdin.write('.exit\n');

test/parallel/test-repl-require-self-referential.js

@@ -23,5 +23,4 @@ child.on('exit', common.mustCall(() => {
 }));
 
 child.stdin.write('require("self_ref");\n');
-child.stdin.write('.exit');
-child.stdin.end();
+child.stdin.write('.exit\n');