Skip to content

Commit f1cada1

Browse files
committed
test: improve test names
1 parent aaf0928 commit f1cada1

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

test/parallel/test-sqlite.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,7 @@ suite('session extension', () => {
795795
);
796796
});
797797

798-
test('trying to create session when database is closed results in exception', (t) => {
798+
test('database.createSession() - closed database results in exception', (t) => {
799799
const database = new DatabaseSync(':memory:');
800800
database.close();
801801
t.assert.throws(() => {
@@ -806,7 +806,7 @@ suite('session extension', () => {
806806
});
807807
});
808808

809-
test('trying to create changeset when database is closed results in exception', (t) => {
809+
test('session.changeset() - closed database results in exception', (t) => {
810810
const database = new DatabaseSync(':memory:');
811811
const session = database.createSession();
812812
database.close();
@@ -818,7 +818,7 @@ suite('session extension', () => {
818818
});
819819
});
820820

821-
test('trying to apply a changeset when database is closed results in exception', (t) => {
821+
test('database.applyChangeset() - closed database results in exception', (t) => {
822822
const database = new DatabaseSync(':memory:');
823823
const session = database.createSession();
824824
const changeset = session.changeset();
@@ -831,7 +831,7 @@ suite('session extension', () => {
831831
});
832832
});
833833

834-
test('setting options.table causes only one table to be tracked', (t) => {
834+
test('database1.createSession() - use table option to track specific table', (t) => {
835835
const database1 = new DatabaseSync(':memory:');
836836
const database2 = new DatabaseSync(':memory:');
837837

@@ -892,7 +892,7 @@ suite('session extension', () => {
892892
};
893893
};
894894

895-
test('conflict while applying changeset (default abort)', (t) => {
895+
test('database.applyChangeset() - conflict with default behavior (abort)', (t) => {
896896
const { database2, changeset } = prepareConflict();
897897
// When changeset is aborted due to a conflict, applyChangeset should return false
898898
t.assert.strictEqual(database2.applyChangeset(changeset), false);
@@ -901,7 +901,7 @@ suite('session extension', () => {
901901
[{ value: 'world' }]); // unchanged
902902
});
903903

904-
test('conflict while applying changeset (explicit abort)', (t) => {
904+
test('database.applyChangeset() - conflict with SQLITE_CHANGESET_ABORT', (t) => {
905905
const { database2, changeset } = prepareConflict();
906906
const result = database2.applyChangeset(changeset, {
907907
onConflict: SQLITE_CHANGESET_ABORT
@@ -913,7 +913,7 @@ suite('session extension', () => {
913913
[{ value: 'world' }]); // unchanged
914914
});
915915

916-
test('conflict while applying changeset (replacement)', (t) => {
916+
test('database.applyChangeset() - conflict with SQLITE_CHANGESET_REPLACE', (t) => {
917917
const { database2, changeset } = prepareConflict();
918918
const result = database2.applyChangeset(changeset, {
919919
onConflict: SQLITE_CHANGESET_REPLACE
@@ -925,7 +925,7 @@ suite('session extension', () => {
925925
[{ value: 'hello' }, { value: 'foo' }]); // replaced
926926
});
927927

928-
test('conflict while applying changeset (omit)', (t) => {
928+
test('database.applyChangeset() - conflict with SQLITE_CHANGESET_OMIT', (t) => {
929929
const { database2, changeset } = prepareConflict();
930930
const result = database2.applyChangeset(changeset, {
931931
onConflict: SQLITE_CHANGESET_OMIT
@@ -937,13 +937,13 @@ suite('session extension', () => {
937937
[{ value: 'world' }, { value: 'foo' }]); // Conflicting change omitted
938938
});
939939

940-
test('constants are defined', (t) => {
940+
test('session related constants are defined', (t) => {
941941
t.assert.strictEqual(SQLITE_CHANGESET_OMIT, 0);
942942
t.assert.strictEqual(SQLITE_CHANGESET_REPLACE, 1);
943943
t.assert.strictEqual(SQLITE_CHANGESET_ABORT, 2);
944944
});
945945

946-
test('allow filtering changes', (t) => {
946+
test('database.createSession() - filter changes', (t) => {
947947
const database1 = new DatabaseSync(':memory:');
948948
const database2 = new DatabaseSync(':memory:');
949949
const createTableSql = 'CREATE TABLE data1(key INTEGER PRIMARY KEY); CREATE TABLE data2(key INTEGER PRIMARY KEY);';
@@ -968,7 +968,7 @@ suite('session extension', () => {
968968
t.assert.strictEqual(data2Rows.length, 5);
969969
});
970970

971-
test('specify other database', (t) => {
971+
test('database.createSession() - specify other database', (t) => {
972972
const database = new DatabaseSync(':memory:');
973973
const session = database.createSession();
974974
const sessionMain = database.createSession({
@@ -985,7 +985,7 @@ suite('session extension', () => {
985985
t.assert.strictEqual(sessionTest.changeset().length, 0);
986986
});
987987

988-
test('wrong arguments database.createSession()', (t) => {
988+
test('database.createSession() - wrong arguments', (t) => {
989989
const database = new DatabaseSync(':memory:');
990990
t.assert.throws(() => {
991991
database.createSession(null);
@@ -1013,7 +1013,7 @@ suite('session extension', () => {
10131013
});
10141014
});
10151015

1016-
test('wrong arguments database.applyChangeset()', (t) => {
1016+
test('database.applyChangeset() - wrong arguments', (t) => {
10171017
const database = new DatabaseSync(':memory:');
10181018
const session = database.createSession();
10191019
t.assert.throws(() => {
@@ -1049,7 +1049,7 @@ suite('session extension', () => {
10491049
});
10501050
});
10511051

1052-
test('generate patchset', (t) => {
1052+
test('session.patchset()', (t) => {
10531053
const database = new DatabaseSync(':memory:');
10541054
database.exec('CREATE TABLE data(key INTEGER PRIMARY KEY, value TEXT)');
10551055

0 commit comments

Comments
 (0)