Skip to content

Commit f5f196f

Browse files
committed
fix order
1 parent a0fbdb1 commit f5f196f

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

doc/api/n-api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2302,11 +2302,11 @@ typedef enum {
23022302
napi_uint16_array,
23032303
napi_int32_array,
23042304
napi_uint32_array,
2305+
napi_float16_array,
23052306
napi_float32_array,
23062307
napi_float64_array,
23072308
napi_bigint64_array,
23082309
napi_biguint64_array,
2309-
napi_float16_array
23102310
} napi_typedarray_type;
23112311
```
23122312

src/js_native_api_types.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,11 @@ typedef enum {
101101
napi_uint16_array,
102102
napi_int32_array,
103103
napi_uint32_array,
104+
napi_float16_array,
104105
napi_float32_array,
105106
napi_float64_array,
106107
napi_bigint64_array,
107108
napi_biguint64_array,
108-
napi_float16_array,
109109
} napi_typedarray_type;
110110

111111
typedef enum {

src/js_native_api_v8.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3301,6 +3301,8 @@ napi_status NAPI_CDECL napi_get_typedarray_info(napi_env env,
33013301
*type = napi_int32_array;
33023302
} else if (value->IsUint32Array()) {
33033303
*type = napi_uint32_array;
3304+
} else if (value->IsFloat16Array()) {
3305+
*type = napi_float16_array;
33043306
} else if (value->IsFloat32Array()) {
33053307
*type = napi_float32_array;
33063308
} else if (value->IsFloat64Array()) {
@@ -3309,8 +3311,6 @@ napi_status NAPI_CDECL napi_get_typedarray_info(napi_env env,
33093311
*type = napi_bigint64_array;
33103312
} else if (value->IsBigUint64Array()) {
33113313
*type = napi_biguint64_array;
3312-
} else if (value->IsFloat16Array()) {
3313-
*type = napi_float16_array;
33143314
}
33153315
}
33163316

test/js-native-api/test_typedarray/test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ assert.strictEqual(externalResult[2], 2);
4141
// Validate creation of all kinds of TypedArrays
4242
const buffer = new ArrayBuffer(128);
4343
const arrayTypes = [ Int8Array, Uint8Array, Uint8ClampedArray, Int16Array,
44-
Uint16Array, Int32Array, Uint32Array, Float32Array,
45-
Float64Array, BigInt64Array, BigUint64Array, Float16Array ];
44+
Uint16Array, Int32Array, Uint32Array, Float16Array,
45+
Float32Array, Float64Array, BigInt64Array, BigUint64Array ];
4646

4747
arrayTypes.forEach((currentType) => {
4848
const template = Reflect.construct(currentType, buffer);
@@ -64,8 +64,8 @@ arrayTypes.forEach((currentType) => {
6464
});
6565

6666
const nonByteArrayTypes = [ Int16Array, Uint16Array, Int32Array, Uint32Array,
67-
Float32Array, Float64Array,
68-
BigInt64Array, BigUint64Array, Float16Array ];
67+
Float16Array, Float32Array, Float64Array,
68+
BigInt64Array, BigUint64Array ];
6969
nonByteArrayTypes.forEach((currentType) => {
7070
const template = Reflect.construct(currentType, buffer);
7171
assert.throws(() => {

0 commit comments

Comments
 (0)