Skip to content

Commit faba50d

Browse files
committed
test: remove --always-turbofan flag
It was removed from V8. Refs: v8/v8@7779ff0 PR-URL: #59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 5623194 commit faba50d

File tree

4 files changed

+18
-10
lines changed

4 files changed

+18
-10
lines changed

test/fixtures/linux-perf-logger.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
process.stdout.write(`${process.pid}`);
44

5+
const wantOptimization = !process.argv.includes('--no-opt');
6+
57
const testRegex = /test-regex/gi;
68

79
function functionOne() {
@@ -14,4 +16,16 @@ function functionTwo() {
1416
functionOne();
1517
}
1618

19+
if (wantOptimization) {
20+
%PrepareFunctionForOptimization(functionOne);
21+
%PrepareFunctionForOptimization(functionTwo);
22+
}
23+
24+
functionTwo();
25+
26+
if (wantOptimization) {
27+
%OptimizeFunctionOnNextCall(functionOne);
28+
%OptimizeFunctionOnNextCall(functionTwo);
29+
}
30+
1731
functionTwo();

test/v8-updates/test-linux-perf-logger.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ tmpdir.refresh();
4242
const testCases = [
4343
{
4444
title: '--perf-basic-prof interpreted',
45-
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--no-opt'],
45+
nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof', '--no-turbo-inlining', '--no-opt'],
4646
matches: [
4747
'JS:~functionOne .+/linux-perf-logger.js',
4848
'JS:~functionTwo .+/linux-perf-logger.js',
@@ -55,8 +55,7 @@ const testCases = [
5555
},
5656
{
5757
title: '--perf-basic-prof compiled',
58-
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan',
59-
'--minimum-invocations-before-optimization=0'],
58+
nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof', '--no-turbo-inlining'],
6059
matches: [
6160
String.raw`RegExp\.> src: 'test-regex' flags: 'gi'`,
6261
'JS:~functionOne .+/linux-perf-logger.js',
@@ -68,7 +67,7 @@ const testCases = [
6867
},
6968
{
7069
title: '--perf-basic-prof-only-functions interpreted',
71-
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--no-opt'],
70+
nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof-only-functions', '--no-turbo-inlining', '--no-opt'],
7271
matches: [
7372
'JS:~functionOne .+/linux-perf-logger.js',
7473
'JS:~functionTwo .+/linux-perf-logger.js',
@@ -81,8 +80,7 @@ const testCases = [
8180
},
8281
{
8382
title: '--perf-basic-prof-only-functions compiled',
84-
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan',
85-
'--minimum-invocations-before-optimization=0'],
83+
nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof-only-functions', '--no-turbo-inlining'],
8684
matches: [
8785
'JS:~functionOne .+/linux-perf-logger.js',
8886
'JS:~functionTwo .+/linux-perf-logger.js',

test/v8-updates/test-linux-perf.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ const perfCompiledFramesArgs = [
6161
'--',
6262
process.execPath,
6363
...nodeCommonFlags,
64-
'--always-turbofan',
6564
fixtures.path('linux-perf.js'),
6665
`${sleepTime}`,
6766
`${repeat}`,

tools/test.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1677,9 +1677,6 @@ def Main():
16771677
if options.check_deopts:
16781678
options.node_args.append("--trace-opt")
16791679
options.node_args.append("--trace-file-names")
1680-
# --always-turbofan is needed because many tests do not run long enough for
1681-
# the optimizer to kick in, so this flag will force it to run.
1682-
options.node_args.append("--always-turbofan")
16831680
options.progress = "deopts"
16841681

16851682
if options.error_reporter:

0 commit comments

Comments
 (0)