From 57dac39754a65c57153e43556d665efb16b48a35 Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Wed, 5 Mar 2025 16:10:21 -0500 Subject: [PATCH] test: remove redundant tls test for no-host --- test/parallel/test-tls-connect-no-host.js | 33 ----------------------- 1 file changed, 33 deletions(-) delete mode 100644 test/parallel/test-tls-connect-no-host.js diff --git a/test/parallel/test-tls-connect-no-host.js b/test/parallel/test-tls-connect-no-host.js deleted file mode 100644 index 97b95332c47c2e..00000000000000 --- a/test/parallel/test-tls-connect-no-host.js +++ /dev/null @@ -1,33 +0,0 @@ -'use strict'; -const common = require('../common'); -const fixtures = require('../common/fixtures'); - -if (!common.hasCrypto) - common.skip('missing crypto'); - -const tls = require('tls'); -const assert = require('assert'); - -const cert = fixtures.readKey('rsa_cert.crt'); -const key = fixtures.readKey('rsa_private.pem'); - -// https://github.com/nodejs/node/issues/1489 -// tls.connect(options) with no options.host should accept a cert with -// CN:'localhost' -const server = tls.createServer({ - key, - cert -}).listen(0, common.mustCall(function() { - const socket = tls.connect({ - port: this.address().port, - ca: cert, - // No host set here. 'localhost' is the default, - // but tls.checkServerIdentity() breaks before the fix with: - // Error: Hostname/IP doesn't match certificate's altnames: - // "Host: undefined. is not cert's CN: localhost" - }, common.mustCall(function() { - assert(socket.authorized); - socket.destroy(); - server.close(); - })); -}));