src: use String::WriteV2() in TwoByteValue #58164

tniessen · 2025-05-04T15:34:31Z

Since String::Write() is deprecated, use String::WriteV2() instead.

Since `String::Write()` is deprecated, use `String::WriteV2()` instead.

codecov · 2025-05-04T16:23:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (6de55f7) to head (eb4a606).
Report is 306 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #58164   +/-   ##
=======================================
  Coverage   90.17%   90.18%           
=======================================
  Files         630      630           
  Lines      186503   186502    -1     
  Branches    36614    36612    -2     
=======================================
+ Hits       168187   168200   +13     
+ Misses      11124    11116    -8     
+ Partials     7192     7186    -6

Files with missing lines	Coverage Δ
src/util.cc	`86.86% <100.00%> (-0.03%)`	⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-05-05T03:04:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66603/

nodejs-github-bot · 2025-05-08T18:12:36Z

Commit Queue failed

- Loading data for nodejs/node/pull/58164
✔  Done loading data for nodejs/node/pull/58164
----------------------------------- PR info ------------------------------------
Title      src: use String::WriteV2() in TwoByteValue (#58164)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:src-twobytevalue-writev2 -> nodejs:main
Labels     c++, v8 engine, author ready, needs-ci
Commits    1
 - src: use String::WriteV2() in TwoByteValue
Committers 1
 - Tobias Nießen <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58164
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58164
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 04 May 2025 15:34:31 GMT
   ✔  Approvals: 6
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58164#pullrequestreview-2813498914
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/58164#pullrequestreview-2813505928
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58164#pullrequestreview-2813533305
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/58164#pullrequestreview-2813696863
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/58164#pullrequestreview-2815817883
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58164#pullrequestreview-2820020780
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2025-05-05T03:04:00Z: https://ci.nodejs.org/job/node-test-pull-request/66603/
- Querying data for job/node-test-pull-request/66603/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/14913152558

tniessen · 2025-05-08T18:40:42Z

@nodejs/build I am not sure why the commit queue says "Last GitHub CI failed", nor do I know what's up with the failed node-test-commit-v8-linux.

nodejs-github-bot · 2025-05-09T02:33:23Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6546/

nodejs-github-bot · 2025-05-09T02:33:27Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6546/

nodejs-github-bot · 2025-05-09T02:33:33Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6546/

richardlau · 2025-05-09T02:54:46Z

nor do I know what's up with the failed node-test-commit-v8-linux.

https://ci.nodejs.org/job/node-test-commit-v8-linux/6529/ was started by the automation because this PR was labelled v8 engine, and failed because ncu-ci from node-core-utils is not setting COMMIT_SHA_CHECK when starting the job. It's a one line fix (but I'm struggling with writing a unit test for it in the existing framework): nodejs/node-core-utils#928

https://ci.nodejs.org/job/node-test-commit-v8-linux/6545/ failed because the COMMIT_SHA_CHECK parameter did not match the SHA of the head commit of this pull request. I submitted https://ci.nodejs.org/job/node-test-commit-v8-linux/6546/ with the correct value for the parameter.

nodejs-github-bot · 2025-05-09T03:15:48Z

Landed in 8debf0b

tniessen · 2025-05-09T08:12:29Z

Thank you @richardlau!

Since `String::Write()` is deprecated, use `String::WriteV2()` instead. PR-URL: #58164 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]>

aduh95 · 2025-06-10T10:03:01Z

Adding dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. as it looks like WriteV2 is not available on 22.x.

src: use String::WriteV2() in TwoByteValue

eb4a606

Since `String::Write()` is deprecated, use `String::WriteV2()` instead.

tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency. labels May 4, 2025

nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 4, 2025

juanarbol approved these changes May 4, 2025

View reviewed changes

joyeecheung approved these changes May 4, 2025

View reviewed changes

anonrig approved these changes May 4, 2025

View reviewed changes

daeyeon approved these changes May 5, 2025

View reviewed changes

daeyeon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 5, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2025

Flarna approved these changes May 5, 2025

View reviewed changes

jasnell approved these changes May 7, 2025

View reviewed changes

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 8, 2025

tniessen removed the v8 engine Issues and PRs related to the V8 dependency. label May 8, 2025

richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 9, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2025

nodejs-github-bot merged commit 8debf0b into nodejs:main May 9, 2025
86 checks passed

github-actions bot mentioned this pull request May 20, 2025

2025-05-21, Version 24.1.0 (Current) #58406

Merged

aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jun 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

src: use String::WriteV2() in TwoByteValue #58164

src: use String::WriteV2() in TwoByteValue #58164

Uh oh!

tniessen commented May 4, 2025

Uh oh!

codecov bot commented May 4, 2025 •

edited

Loading

Uh oh!

nodejs-github-bot commented May 5, 2025

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

tniessen commented May 8, 2025 •

edited

Loading

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

richardlau commented May 9, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

tniessen commented May 9, 2025

Uh oh!

aduh95 commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

src: use String::WriteV2() in TwoByteValue #58164

src: use String::WriteV2() in TwoByteValue #58164

Uh oh!

Conversation

tniessen commented May 4, 2025

Uh oh!

codecov bot commented May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented May 5, 2025

Uh oh!

nodejs-github-bot commented May 8, 2025

Uh oh!

tniessen commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

richardlau commented May 9, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented May 9, 2025

Uh oh!

tniessen commented May 9, 2025

Uh oh!

aduh95 commented Jun 10, 2025

Uh oh!

Uh oh!

codecov bot commented May 4, 2025 •

edited

Loading

tniessen commented May 8, 2025 •

edited

Loading