cluster: fix port reuse between cluster #60141
Merged
+118
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
cluster
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60141 +/- ##
==========================================
+ Coverage 88.45% 88.52% +0.06%
==========================================
Files 703 703
Lines 207546 207821 +275
Branches 40016 40014 -2
==========================================
+ Hits 183595 183977 +382
+ Misses 15956 15857 -99
+ Partials 7995 7987 -8
🚀 New features to boost your workflow:
|
|
@islandryu - Thank you for proposing this change, the underlying issue is causing trouble for us with TCP, UDP, and HTTP servers: #60086. Any chance of getting this merged anytime in the near future? |
Member
Author
|
We’ll need to get this reviewed before it can move forward. @nodejs/cluster |
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
islandryu
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 903f647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60086
If the
message.indexpassed toqueryServerbecomes out of sync due to errors or other issues, it may prevent a cluster from reusing a port that was acquired by another cluster.To address this, I modified the code so that the handle key no longer includes the index (except when the port number is 0), and only the latest handle corresponding to a successfully acquired port is stored.