src: fix off-thread cert loading in bundled cert mode #60764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60764 +/- ##
==========================================
+ Coverage 88.55% 88.56% +0.01%
==========================================
Files 703 703
Lines 208256 208260 +4
Branches 40147 40158 +11
==========================================
+ Hits 184427 184454 +27
+ Misses 15838 15812 -26
- Partials 7991 7994 +3
🚀 New features to boost your workflow:
|
Collaborator
https://redirect.github.com/nodejs/node/pull/59856 had an typo/mistake in the skip conditions so that it is skipping when --use-openssl-ca or --openssl-system-ca-path (configure time) are NOT used, even though they should be skipped only when those ARE used (which is not the default for default builds). This change fixes that so that the perf numbers in that PR is true for the default build.
joyeecheung
force-pushed
the
fix-off-thread-crypto
branch
from
e1e170d to
cae0df4
Compare
jasnell
approved these changes
Nov 20, 2025
gurgunday
approved these changes
Nov 20, 2025
anonrig
approved these changes
Nov 23, 2025
| { | ||
| Mutex::ScopedLock cli_lock(node::per_process::cli_options_mutex); | ||
| if (!per_process::cli_options->ssl_openssl_cert_store) { | ||
| if (per_process::cli_options->ssl_openssl_cert_store) { |
Member
There was a problem hiding this comment.
Would you mind adding a comment to this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redirect.github.com/nodejs/node/pull/59856 had an typo/mistake in the skip conditions so that it is skipping when --use-openssl-ca or --openssl-system-ca-path (configure time) are NOT used, even though they should be skipped only when those ARE used (which is not the default for default builds). This change fixes that so that the perf numbers in that PR is true for the default build.
Thanks @deepak1556 for catching it!