util: honor breakLength Infinity when depth is Infinity #60783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60783 +/- ##
==========================================
+ Coverage 88.04% 88.54% +0.50%
==========================================
Files 703 703
Lines 208260 208269 +9
Branches 40068 40169 +101
==========================================
+ Hits 183360 184419 +1059
+ Misses 16840 15884 -956
+ Partials 8060 7966 -94
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util.inspect()was still inserting line breaks when bothbreakLengthanddepthwere set toInfinity. Grouping logic and the compactinline heuristics were ignoring the special “no wrapping” intent. This change adds an
isUnlimitedDepth()guard so the line-wrapping pathsare skipped when the user explicitly asks for infinite width and depth.
Fixes: #60475