Skip to content

Commit 53591f9

Browse files
authored
chore: Minor changes on download page (#7367)
* chore: mobile layout and skeleton sizes * chore: layout on not-found page * chore: mobile skeleton size * chore: review updates * chore: error page layout
1 parent c8e604f commit 53591f9

File tree

7 files changed

+21
-16
lines changed

7 files changed

+21
-16
lines changed

apps/site/app/[locale]/error.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const ErrorPage: FC<{ error: Error }> = () => {
1111
const t = useTranslations();
1212

1313
return (
14-
<GlowingBackdropLayout>
14+
<GlowingBackdropLayout kind="default">
1515
500
1616
<h1 className="special -mt-4 text-center">
1717
{t('layouts.error.internalServerError.title')}

apps/site/app/[locale]/not-found.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const NotFoundPage: FC = () => {
1212
const t = useTranslations();
1313

1414
return (
15-
<GlowingBackdropLayout>
15+
<GlowingBackdropLayout kind="default">
1616
404
1717
<h1 className="special -mt-4 text-center">
1818
{t('layouts.error.notFound.title')}

apps/site/components/Downloads/Release/BlogPostLink.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,14 @@
33
import type { FC, PropsWithChildren } from 'react';
44
import { useContext } from 'react';
55

6-
import LinkWithArrow from '@/components/Downloads/Release/LinkWithArrow';
6+
import Link from '@/components/Link';
77
import { ReleaseContext } from '@/providers/releaseProvider';
88

99
const BlogPostLink: FC<PropsWithChildren> = ({ children }) => {
1010
const { release } = useContext(ReleaseContext);
1111
const version = release.versionWithPrefix;
1212

13-
return (
14-
<LinkWithArrow href={`/blog/release/${version}`}>{children}</LinkWithArrow>
15-
);
13+
return <Link href={`/blog/release/${version}`}>{children}</Link>;
1614
};
1715

1816
export default BlogPostLink;

apps/site/components/Downloads/Release/PlatformDropdown.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const PlatformDropdown: FC = () => {
6464
placeholder={t('layouts.download.dropdown.unknown')}
6565
ariaLabel={t('layouts.download.dropdown.installMethod')}
6666
onChange={platform => platform && release.setPlatform(platform)}
67-
className="min-w-20"
67+
className="min-w-28"
6868
inline={true}
6969
/>
7070
);

apps/site/components/Downloads/Release/PrebuiltDownloadButtons.tsx

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,16 @@ const PrebuiltDownloadButtons: FC = () => {
3030
: '';
3131

3232
return (
33-
<div className="my-4 flex flex-wrap gap-2">
33+
<div className="my-4 flex flex-col gap-2 sm:flex-row">
3434
<Skeleton
3535
loading={os === 'LOADING' || platform === ''}
3636
hide={OS_NOT_SUPPORTING_INSTALLERS.includes(os)}
3737
>
38-
<Button href={installerUrl} size="small" className="min-w-56">
38+
<Button
39+
href={installerUrl}
40+
size="small"
41+
className="w-full min-w-56 sm:w-auto"
42+
>
3943
<CloudArrowDownIcon />
4044

4145
{t('layouts.download.buttons.installer', {
@@ -46,7 +50,11 @@ const PrebuiltDownloadButtons: FC = () => {
4650
</Skeleton>
4751

4852
<Skeleton loading={os === 'LOADING' || platform === ''}>
49-
<Button href={binaryUrl} size="small" className="min-w-56">
53+
<Button
54+
href={binaryUrl}
55+
size="small"
56+
className="w-full min-w-56 sm:w-auto"
57+
>
5058
<CloudArrowDownIcon />
5159

5260
{t('layouts.download.buttons.binary', {

apps/site/components/Downloads/Release/ReleaseCodeBox.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ const ReleaseCodeBox: FC = () => {
111111
)}
112112

113113
<Skeleton loading={renderSkeleton}>
114-
<CodeBox language={displayName} className="min-h-[16rem]">
114+
<CodeBox language={displayName} className="min-h-[16.5rem]">
115115
<code dangerouslySetInnerHTML={{ __html: parsedSnippets }} />
116116
</CodeBox>
117117
</Skeleton>

apps/site/layouts/GlowingBackdrop.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@ import WithNavBar from '@/components/withNavBar';
88
import styles from './layouts.module.css';
99

1010
type GlowingBackdropLayoutProps = PropsWithChildren<{
11-
kind?: 'home';
11+
kind?: 'home' | 'default';
1212
}>;
1313

14-
const GlowingBackdropLayout: FC<GlowingBackdropLayoutProps> = ({
15-
kind = 'home',
16-
children,
17-
}) => (
14+
const GlowingBackdropLayout: FC<
15+
PropsWithChildren<GlowingBackdropLayoutProps>
16+
> = ({ kind = 'home', children }) => (
1817
<>
1918
<WithNavBar />
2019
<div className={styles.centeredLayout}>

0 commit comments

Comments
 (0)