Skip to content

Commit 5b1dc26

Browse files
committed
fix(ui): Learn Page Landmark Accessibility issues
1 parent 7a949e8 commit 5b1dc26

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

packages/ui-components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@node-core/ui-components",
3-
"version": "1.5.4",
3+
"version": "1.5.5",
44
"type": "module",
55
"exports": {
66
"./*": [

packages/ui-components/src/Common/Banner/index.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@ const Banner: FC<PropsWithChildren<BannerProps>> = ({
1010
type = 'default',
1111
children,
1212
}) => (
13-
<div className={`${styles.banner} ${styles[type] || styles.default}`}>
13+
<section
14+
className={`${styles.banner} ${styles[type] || styles.default}`}
15+
role="region"
16+
aria-label="Announcement"
17+
>
1418
{children}
15-
</div>
19+
</section>
1620
);
1721

1822
export default Banner;

packages/ui-components/src/Containers/MetaBar/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const MetaBar: FC<MetaBarProps> = ({
3131
);
3232

3333
return (
34-
<div className={styles.wrapper}>
34+
<aside className={styles.wrapper} aria-label="Article metadata">
3535
<dl>
3636
{Object.entries(items)
3737
.filter(([, value]) => !!value)
@@ -65,7 +65,7 @@ const MetaBar: FC<MetaBarProps> = ({
6565
</>
6666
)}
6767
</dl>
68-
</div>
68+
</aside>
6969
);
7070
};
7171

0 commit comments

Comments
 (0)