refactor: enhance buildReleaseArtifacts

Author: canerakdas

apps/site/components/withDownloadArchive.tsx

@@ -11,7 +11,7 @@ import {
 type DownloadArchive = ReturnType<typeof buildReleaseArtifacts>;
 
 type WithDownloadArchiveProps = {
-  children: FC<DownloadArchive>;
+  children: FC<DownloadArchive & { majorVersions: Array<string> }>;
 };
 
 /**
@@ -37,13 +37,9 @@ const WithDownloadArchive: FC<WithDownloadArchiveProps> = async ({
   }
 
   const majorVersions = releaseData.map(release => release.versionWithPrefix);
-  const releaseArtifacts = buildReleaseArtifacts(
-    release,
-    version,
-    majorVersions
-  );
+  const releaseArtifacts = buildReleaseArtifacts(release, version);
 
-  return <Component {...releaseArtifacts} />;
+  return <Component {...releaseArtifacts} majorVersions={majorVersions} />;
 };
 
 export default WithDownloadArchive;

apps/site/pages/en/download/archive.mdx

@@ -4,7 +4,7 @@ layout: download-archive
 ---
 
 <WithDownloadArchive>
-  {({ binaries, installers, version, release, sources, majors }) => (
+  {({ binaries, installers, version, release, sources, majorVersions }) => (
     <>
       <h1>Download Node.js® {version}</h1>
       <ReleaseOverview release={release} />
@@ -41,7 +41,7 @@ layout: download-archive
           <h2 className="inline">Other releases</h2>
         </summary>
         <ul>
-          {majors.map(version => (
+          {majorVersions.map(version => (
             <li key={version}>
               <Link href={`/download/${version}`}>
                 <h3>Node.js {version}</h3>

apps/site/util/downloadUtils/archive.tsx

@@ -90,8 +90,7 @@ const getCompatibleArtifacts = ({
 
 export const buildReleaseArtifacts = (
   release: NodeRelease,
-  version: string,
-  majors: Array<string>
+  version: string
 ) => {
   const minorVersion = release.minorVersions.find(
     ({ versionWithPrefix }) => versionWithPrefix === version
@@ -123,9 +122,7 @@ export const buildReleaseArtifacts = (
       }),
     },
     version: version,
-    minors: enrichedRelease.minorVersions,
     release: enrichedRelease,
-    majors: majors,
   };
 };