chore: enforce consistent object-shorthand (#7851)

canerakdas · web-flow · commit a459447336d9 · 2025-07-09T14:59:43.000Z
* chore: force object shorthand

* chore: revert guid changes

* chore: content stylings

* fix: mixed object shorthand
diff --git a/apps/site/app/[locale]/next-data/api-data/route.ts b/apps/site/app/[locale]/next-data/api-data/route.ts
@@ -48,7 +48,7 @@ export const GET = async () => {
         const deflatedSource = deflateSync(cleanedContent).toString('base64');
 
         return {
-          filename,
+          filename: filename,
           pathname: getPathnameForApiFile(name, versionWithPrefix),
           content: deflatedSource,
         };
diff --git a/apps/site/app/[locale]/next-data/page-data/route.ts b/apps/site/app/[locale]/next-data/page-data/route.ts
@@ -35,15 +35,15 @@ export const GET = async () => {
       const cleanedContent = parseRichTextIntoPlainText(matter(source).content);
 
       // Deflates a String into a base64 string-encoded (zlib compressed)
-      const deflatedSource = deflateSync(cleanedContent).toString('base64');
+      const content = deflateSync(cleanedContent).toString('base64');
 
       // Returns metadata of each page available on the Website
       return {
         filename,
         pathname,
         title,
         description,
-        content: deflatedSource,
+        content,
       };
     });
 
diff --git a/apps/site/app/[locale]/page.tsx b/apps/site/app/[locale]/page.tsx
@@ -134,11 +134,11 @@ const getPage: FC<DynamicParams> = async props => {
 
     // Metadata and shared Context to be available through the lifecycle of the page
     const sharedContext = {
-      frontmatter,
-      headings,
+      frontmatter: frontmatter,
+      headings: headings,
       pathname: `/${pathname}`,
-      readingTime,
-      filename,
+      readingTime: readingTime,
+      filename: filename,
     };
 
     // Defines a shared Server Context for the Client-Side
diff --git a/apps/site/components/Downloads/Release/VersionDropdown.tsx b/apps/site/components/Downloads/Release/VersionDropdown.tsx
@@ -38,12 +38,12 @@ const VersionDropdown: FC = () => {
     );
 
     if (release?.status === 'LTS' && pathname.includes('current')) {
-      redirect({ href: '/download', locale });
+      redirect({ href: '/download', locale: locale });
       return;
     }
 
     if (release?.status === 'Current' && !pathname.includes('current')) {
-      redirect({ href: '/download/current', locale });
+      redirect({ href: '/download/current', locale: locale });
       return;
     }
 
diff --git a/apps/site/components/withAvatarGroup.tsx b/apps/site/components/withAvatarGroup.tsx
@@ -21,9 +21,9 @@ const WithAvatarGroup: FC<WithAvatarGroupProps> = ({
 }) => (
   <AvatarGroup
     avatars={getAuthors({
-      usernames: usernames,
-      names: names,
-      clickable: clickable,
+      usernames,
+      names,
+      clickable,
     })}
     as={Link}
     {...props}
diff --git a/apps/site/components/withBreadcrumbs.tsx b/apps/site/components/withBreadcrumbs.tsx
@@ -57,7 +57,9 @@ const WithBreadcrumbs: FC<WithBreadcrumbsProps> = ({ navKeys = [] }) => {
         // Goes deeper on the tree of items if there are any.
         currentNode = items;
 
-        return label ? [...breadcrumbs, { label, href: link }] : breadcrumbs;
+        return label
+          ? [...breadcrumbs, { label: label, href: link }]
+          : breadcrumbs;
       }
 
       return breadcrumbs;
diff --git a/apps/site/components/withFooter.tsx b/apps/site/components/withFooter.tsx
@@ -20,7 +20,10 @@ const WithFooter: FC = () => {
   // Add OpenJS link
   updatedFooterLinks.push(footerLinks.at(-1)!);
 
-  const navigation = { socialLinks, footerLinks: updatedFooterLinks };
+  const navigation = {
+    socialLinks: socialLinks,
+    footerLinks: updatedFooterLinks,
+  };
 
   return <Footer navigation={navigation} as={Link} pathname={pathname} />;
 };
diff --git a/apps/site/components/withNavBar.tsx b/apps/site/components/withNavBar.tsx
@@ -48,9 +48,9 @@ const WithNavBar: FC = () => {
 
       <NavBar
         navItems={navigationItems.map(([, { label, link, target }]) => ({
-          link,
+          link: link,
           text: label,
-          target,
+          target: target,
         }))}
         pathname={pathname}
         as={Link}
diff --git a/apps/site/hooks/react-generic/useSiteNavigation.ts b/apps/site/hooks/react-generic/useSiteNavigation.ts
@@ -49,7 +49,7 @@ const useSiteNavigation = () => {
       ] => [
         key,
         {
-          target,
+          target: target,
           label: label ? getFormattedMessage(label, key) : '',
           link: link ? replaceLinkWithContext(link, context[key]) : '',
           items: items ? mapNavigationEntries(items, context) : [],
diff --git a/apps/site/i18n.tsx b/apps/site/i18n.tsx
@@ -35,7 +35,7 @@ export default getRequestConfig(async ({ requestLocale }) => {
   }
 
   return {
-    locale,
+    locale: locale,
     // This is the dictionary of messages to be loaded
     messages: await loadLocaleDictionary(locale),
     // We always define the App timezone as UTC
diff --git a/apps/site/layouts/Blog.tsx b/apps/site/layouts/Blog.tsx
@@ -24,7 +24,12 @@ const getBlogCategory = (pathname: string) => {
     Number(page)
   );
 
-  return { category, posts, pagination, page: Number(page) };
+  return {
+    category: category,
+    posts: posts,
+    pagination: pagination,
+    page: Number(page),
+  };
 };
 
 const BlogLayout: FC = async () => {
diff --git a/apps/site/next-data/generators/__tests__/websiteFeeds.test.mjs b/apps/site/next-data/generators/__tests__/websiteFeeds.test.mjs
@@ -41,7 +41,7 @@ describe('generateWebsiteFeeds', () => {
         id: blogData.posts[0].slug,
         title: blogData.posts[0].title,
         guid: `${blogData.posts[0].slug}?${date.getTime()}`,
-        date,
+        date: date,
         link: `${base}${blogData.posts[0].slug}`,
       },
     ]);
diff --git a/apps/site/next-data/generators/blogData.mjs b/apps/site/next-data/generators/blogData.mjs
@@ -37,7 +37,14 @@ const getFrontMatter = (filename, source) => {
   // this is the url used for the blog post it based on the category and filename
   const slug = `/blog/${category}/${basename(filename, extname(filename))}`;
 
-  return { title, author, username, date: new Date(date), categories, slug };
+  return {
+    title: title,
+    author: author,
+    username: username,
+    date: new Date(date),
+    categories: categories,
+    slug: slug,
+  };
 };
 
 /**
@@ -103,7 +110,7 @@ const generateBlogData = async () => {
     )
   );
 
-  return { categories: [...blogCategories], posts };
+  return { categories: [...blogCategories], posts: posts };
 };
 
 export default generateBlogData;
diff --git a/apps/site/next-data/generators/releaseData.mjs b/apps/site/next-data/generators/releaseData.mjs
@@ -39,7 +39,7 @@ const generateReleaseData = async () => {
     absolute: false,
   });
 
-  const nodevuOutput = await nodevu({ fetch: fetch });
+  const nodevuOutput = await nodevu({ fetch });
 
   const majors = Object.entries(nodevuOutput).filter(
     ([version, { support }]) => {
@@ -91,7 +91,7 @@ const generateReleaseData = async () => {
 
     return {
       ...support,
-      status,
+      status: status,
       major: latestVersion.semver.major,
       version: latestVersion.semver.raw,
       versionWithPrefix: `v${latestVersion.semver.raw}`,
@@ -101,8 +101,8 @@ const generateReleaseData = async () => {
       v8: latestVersion.dependencies.v8,
       releaseDate: latestVersion.releaseDate,
       modules: latestVersion.modules.version || '',
-      releaseAnnounceLink,
-      minorVersions,
+      releaseAnnounceLink: releaseAnnounceLink,
+      minorVersions: minorVersions,
     };
   });
 };
diff --git a/apps/site/next-data/generators/websiteFeeds.mjs b/apps/site/next-data/generators/websiteFeeds.mjs
@@ -46,7 +46,7 @@ const generateWebsiteFeeds = ({ posts }) => {
             id: post.slug,
             title: post.title,
             author: post.author,
-            date,
+            date: date,
             link: `${canonicalUrl}${post.slug}`,
             guid:
               time > guidTimestampStartDate
diff --git a/apps/site/next.calendar.mjs b/apps/site/next.calendar.mjs
@@ -18,8 +18,8 @@ export const getCalendarEvents = async (calendarId = '', maxResults = 20) => {
   nextWeekDate.setDate(currentDate.getDate() + 7);
 
   const calendarQueryParams = new URLSearchParams({
-    calendarId,
-    maxResults,
+    calendarId: calendarId,
+    maxResults: maxResults,
     singleEvents: true,
     timeZone: 'Etc/Utc',
     key: SHARED_CALENDAR_KEY,
diff --git a/apps/site/next.dynamic.mjs b/apps/site/next.dynamic.mjs
@@ -35,7 +35,7 @@ const getPathname = (path = []) => path.join('/');
 // we use a platform-specific separator to split the pathname
 // since we're using filepaths here and not URL paths
 const mapPathToRoute = (locale = defaultLocale.code, path = '') => ({
-  locale,
+  locale: locale,
   path: path.split(sep),
 });
 
@@ -122,7 +122,7 @@ const getDynamicRouter = async () => {
           `${locale}${normalizedPathname}`
         );
 
-        return { source: fileContent, filename };
+        return { source: fileContent, filename: filename };
       }
 
       // Attempts to read a file or simply (and silently) fail, as the file might
@@ -140,7 +140,7 @@ const getDynamicRouter = async () => {
           fileLanguageContent
         );
 
-        return { source: fileLanguageContent, filename };
+        return { source: fileLanguageContent, filename: filename };
       }
 
       // Prevent infinite loops as if at this point the file does not exist with the default locale
@@ -160,7 +160,7 @@ const getDynamicRouter = async () => {
       // of the same locale for this file and improve read performance
       cachedMarkdownFiles.set(`${locale}${normalizedPathname}`, fileContent);
 
-      return { source: fileContent, filename };
+      return { source: fileContent, filename: filename };
     }
 
     return { filename: '', source: '' };
diff --git a/apps/site/next.mdx.use.mjs b/apps/site/next.mdx.use.mjs
@@ -12,13 +12,13 @@ import WithNodeRelease from './components/withNodeRelease';
  * @satisfies {import('mdx/types').MDXComponents}
  */
 export const mdxComponents = {
-  DownloadReleasesTable: DownloadReleasesTable,
+  DownloadReleasesTable,
   // HOC for getting Node.js Release Metadata
-  WithNodeRelease: WithNodeRelease,
+  WithNodeRelease,
   // HOC for providing Banner Data
-  WithBanner: WithBanner,
+  WithBanner,
   // HOC for providing Badge Data
-  WithBadgeGroup: WithBadgeGroup,
+  WithBadgeGroup,
   // Renders an container for Upcoming Node.js Meetings
-  UpcomingMeetings: UpcomingMeetings,
+  UpcomingMeetings,
 };
diff --git a/apps/site/next.rewrites.mjs b/apps/site/next.rewrites.mjs
@@ -24,7 +24,7 @@ const redirects = async () => {
     // We prevent permanent redirects as in general the redirects are safeguards
     // of legacy or old pages or pages that moved, and in general we don't want permanent redirects
     permanent: false,
-    destination,
+    destination: destination,
   }));
 };
 
@@ -40,7 +40,7 @@ const rewrites = async () => {
   const mappedRewrites = siteRedirects.internal.map(
     ({ source, destination }) => ({
       source: source.replace('/:locale', localesMatch),
-      destination,
+      destination: destination,
     })
   );
 
diff --git a/apps/site/pages/en/learn/getting-started/fetch.md b/apps/site/pages/en/learn/getting-started/fetch.md
@@ -98,7 +98,7 @@ async function streamOllamaCompletion(prompt) {
     headers: {
       'Content-Type': 'application/json',
     },
-    body: JSON.stringify({ prompt, model: 'mistral' }),
+    body: JSON.stringify({ prompt: prompt, model: 'mistral' }),
   });
 
   // You can read about HTTP status codes here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status
diff --git a/apps/site/pages/en/learn/modules/backpressuring-in-streams.md b/apps/site/pages/en/learn/modules/backpressuring-in-streams.md
@@ -613,7 +613,7 @@ import { Readable } from 'node:stream';
 // Create a custom Readable stream
 const myReadableStream = new Readable({
   objectMode: true,
-  read(size) {
+  read: function (size) {
     // Push some data onto the stream
     this.push({ message: 'Hello, world!' });
     this.push(null); // Mark the end of the stream
diff --git a/apps/site/pages/en/learn/modules/how-to-use-streams.md b/apps/site/pages/en/learn/modules/how-to-use-streams.md
@@ -382,7 +382,7 @@ To create a new transform stream, we can pass an `options` object to the `Transf
 const { Transform } = require('node:stream');
 
 const upper = new Transform({
-  transform: function (data, enc, cb) {
+  transform(data, enc, cb) {
     this.push(data.toString().toUpperCase());
     cb();
   },
@@ -393,7 +393,7 @@ const upper = new Transform({
 import { Transform } from 'node:stream';
 
 const upper = new Transform({
-  transform: function (data, enc, cb) {
+  transform(data, enc, cb) {
     this.push(data.toString().toUpperCase());
     cb();
   },
@@ -456,7 +456,7 @@ import { Transform } from 'node:stream';
 
 let errorCount = 0;
 const upper = new Transform({
-  transform: function (data, enc, cb) {
+  transform(data, enc, cb) {
     if (errorCount === 10) {
       return cb(new Error('BOOM!'));
     }
@@ -549,7 +549,7 @@ import { Transform, pipeline } from 'node:stream';
 
 let errorCount = 0;
 const upper = new Transform({
-  transform: function (data, enc, cb) {
+  transform(data, enc, cb) {
     if (errorCount === 10) {
       return cb(new Error('BOOM!'));
     }
@@ -671,7 +671,7 @@ import { Readable } from 'node:stream';
 
 const readable = Readable({
   objectMode: true,
-  read() {
+  read: function () {
     this.push({ hello: 'world' });
     this.push(null);
   },
diff --git a/apps/site/reducers/releaseReducer.ts b/apps/site/reducers/releaseReducer.ts
@@ -22,12 +22,13 @@ export const releaseState: Types.ReleaseState = {
 export const getActions = (
   dispatch: Dispatch<Types.ReleaseAction>
 ): Types.ReleaseDispatchActions => ({
-  setVersion: payload => dispatch({ type: 'SET_VERSION', payload }),
-  setOS: payload => dispatch({ type: 'SET_OS', payload }),
-  setPlatform: payload => dispatch({ type: 'SET_PLATFORM', payload }),
+  setVersion: payload => dispatch({ type: 'SET_VERSION', payload: payload }),
+  setOS: payload => dispatch({ type: 'SET_OS', payload: payload }),
+  setPlatform: payload => dispatch({ type: 'SET_PLATFORM', payload: payload }),
   setInstallMethod: payload =>
-    dispatch({ type: 'SET_INSTALL_METHOD', payload }),
-  setPackageManager: payload => dispatch({ type: 'SET_MANAGER', payload }),
+    dispatch({ type: 'SET_INSTALL_METHOD', payload: payload }),
+  setPackageManager: payload =>
+    dispatch({ type: 'SET_MANAGER', payload: payload }),
 });
 
 const reducer = (
diff --git a/apps/site/scripts/orama-search/get-documents.mjs b/apps/site/scripts/orama-search/get-documents.mjs
@@ -70,7 +70,7 @@ export const siteContent = [...pageData, ...apiData]
       const path = `${pathname}#${slug(section.pageSectionTitle)}`;
 
       return {
-        path,
+        path: path,
         siteSection: uppercaseFirst(siteSection),
         pageTitle: title,
         ...section,
diff --git a/eslint.config.js b/eslint.config.js
@@ -45,6 +45,7 @@ export default [
           },
         },
       ],
+      'object-shorthand': ['error', 'consistent-as-needed'],
     },
   },
 ];
diff --git a/packages/rehype-shiki/src/highlighter.mjs b/packages/rehype-shiki/src/highlighter.mjs
diff --git a/packages/rehype-shiki/src/plugin.mjs b/packages/rehype-shiki/src/plugin.mjs
diff --git a/packages/ui-components/src/Common/BasePagination/useGetPageElements.tsx b/packages/ui-components/src/Common/BasePagination/useGetPageElements.tsx
diff --git a/packages/ui-components/src/Common/Select/index.tsx b/packages/ui-components/src/Common/Select/index.tsx
diff --git a/packages/ui-components/src/Containers/Sidebar/index.tsx b/packages/ui-components/src/Containers/Sidebar/index.tsx
diff --git a/packages/ui-components/src/stylelint/one-utility-class-per-line.mjs b/packages/ui-components/src/stylelint/one-utility-class-per-line.mjs

Original file line number	Diff line number	Diff line change
`@@ -38,12 +38,12 @@ const VersionDropdown: FC = () => {`
`38`	`38`	`);`
`39`	`39`
`40`	`40`	`if (release?.status === 'LTS' && pathname.includes('current')) {`
`41`		`- redirect({ href: '/download', locale });`
	`41`	`+ redirect({ href: '/download', locale: locale });`
`42`	`42`	`return;`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`if (release?.status === 'Current' && !pathname.includes('current')) {`
`46`		`- redirect({ href: '/download/current', locale });`
	`46`	`+ redirect({ href: '/download/current', locale: locale });`
`47`	`47`	`return;`
`48`	`48`	`}`
`49`	`49`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,9 @@ const WithBreadcrumbs: FC<WithBreadcrumbsProps> = ({ navKeys = [] }) => {`
`57`	`57`	`// Goes deeper on the tree of items if there are any.`
`58`	`58`	`currentNode = items;`
`59`	`59`
`60`		`- return label ? [...breadcrumbs, { label, href: link }] : breadcrumbs;`
	`60`	`+ return label`
	`61`	`+ ? [...breadcrumbs, { label: label, href: link }]`
	`62`	`+ : breadcrumbs;`
`61`	`63`	`}`
`62`	`64`
`63`	`65`	`return breadcrumbs;`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ const useSiteNavigation = () => {`
`49`	`49`	`] => [`
`50`	`50`	`key,`
`51`	`51`	`{`
`52`		`- target,`
	`52`	`+ target: target,`
`53`	`53`	`label: label ? getFormattedMessage(label, key) : '',`
`54`	`54`	`link: link ? replaceLinkWithContext(link, context[key]) : '',`
`55`	`55`	`items: items ? mapNavigationEntries(items, context) : [],`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ export default getRequestConfig(async ({ requestLocale }) => {`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`return {`
`38`		`- locale,`
	`38`	`+ locale: locale,`
`39`	`39`	`// This is the dictionary of messages to be loaded`
`40`	`40`	`messages: await loadLocaleDictionary(locale),`
`41`	`41`	`// We always define the App timezone as UTC`