Skip to content

Commit caddf8b

Browse files
committed
fix aria-label a11y
1 parent cb0d824 commit caddf8b

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

apps/site/components/withNavBar.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@ const WithNavBar: FC = () => {
3939
const toggleCurrentTheme = () =>
4040
setTheme(resolvedTheme === 'dark' ? 'light' : 'dark');
4141

42+
const themeToggleAriaLabel =
43+
resolvedTheme === 'dark'
44+
? t('components.common.themeToggle.label.light')
45+
: t('components.common.themeToggle.label.dark');
46+
4247
const changeLanguage = (locale: SimpleLocaleConfig) =>
4348
replace(pathname!, { locale: locale.code });
4449

@@ -63,7 +68,7 @@ const WithNavBar: FC = () => {
6368

6469
<ThemeToggle
6570
onClick={toggleCurrentTheme}
66-
aria-label={t('components.common.themeToggle.label')}
71+
aria-label={themeToggleAriaLabel}
6772
/>
6873

6974
<LanguageDropdown

packages/i18n/src/locales/en.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,10 @@
229229
"label": "Choose Language"
230230
},
231231
"themeToggle": {
232-
"label": "Toggle Dark Mode"
232+
"label": {
233+
"light": "Activate Light Mode",
234+
"dark": "Activate Dark Mode"
235+
}
233236
}
234237
},
235238
"metabar": {

0 commit comments

Comments
 (0)