Skip to content

Commit f96e24c

Browse files
committed
chore: use wait-on instead of delay in test script
Instead of dealying 3 seconds and assuming that will be enough, use `wait-on` to launch `linkinator` once the website is responding.
1 parent efb8c6f commit f96e24c

File tree

2 files changed

+97
-131
lines changed

2 files changed

+97
-131
lines changed

package-lock.json

Lines changed: 94 additions & 128 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"load-schedule": "curl -sS https://raw.githubusercontent.com/nodejs/Release/master/schedule.json -o source/schedule.json",
1414
"start": "npm run serve",
1515
"test": "npm-run-all test:lint test:unit",
16-
"linkinator": "delay 3 && linkinator http://localhost:8080/en/ --recurse --skip \"^(?!http://localhost)\" --verbosity error",
16+
"linkinator": "wait-on http://localhost:8080/en/ && linkinator http://localhost:8080/en/ --recurse --skip \"^(?!http://localhost)\" --verbosity error",
1717
"test:lint": "npm-run-all --parallel --aggregate-output test:lint:*",
1818
"test:lint:js": "standard",
1919
"test:lint:md": "remark -qf .",
@@ -66,7 +66,6 @@
6666
"devDependencies": {
6767
"chokidar": "^3.5.2",
6868
"cross-env": "^7.0.3",
69-
"delay-cli": "^1.1.0",
7069
"faucet": "0.0.1",
7170
"linkinator": "^2.14.0",
7271
"lockfile-lint": "^4.6.2",
@@ -82,6 +81,7 @@
8281
"stylelint": "^13.13.1",
8382
"stylelint-config-twbs-bootstrap": "^2.2.3",
8483
"tape": "^5.3.1",
85-
"vnu-jar": "21.9.2"
84+
"vnu-jar": "21.9.2",
85+
"wait-on": "^6.0.0"
8686
}
8787
}

0 commit comments

Comments
 (0)