Skip to content

Commit fe4dd3d

Browse files
committed
fix i18n aria-label text
1 parent d47d496 commit fe4dd3d

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

apps/site/components/withNavBar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ const WithNavBar: FC = () => {
4141

4242
const themeToggleAriaLabel =
4343
resolvedTheme === 'dark'
44-
? t('components.common.themeToggle.label.light')
45-
: t('components.common.themeToggle.label.dark');
44+
? t('components.common.themeToggle.light')
45+
: t('components.common.themeToggle.dark');
4646

4747
const changeLanguage = (locale: SimpleLocaleConfig) =>
4848
replace(pathname!, { locale: locale.code });

apps/site/tests/e2e/general-behavior.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const locators = {
1414
// Global UI controls
1515
languageDropdownName: englishLocale.components.common.languageDropdown.label,
1616
// default light theme
17-
themeToggleName: englishLocale.components.common.themeToggle.label.light,
17+
themeToggleName: englishLocale.components.common.themeToggle.light,
1818

1919
// Search components (from Orama library)
2020
searchButtonTag: 'orama-button',
@@ -75,7 +75,7 @@ test.describe('Node.js Website', () => {
7575
const initialTheme = await getTheme(page);
7676
const initialAriaLabel = await themeToggle.getAttribute('aria-label');
7777
expect(initialAriaLabel).toBe(
78-
englishLocale.components.common.themeToggle.label[initialTheme]
78+
englishLocale.components.common.themeToggle[initialTheme]
7979
);
8080

8181
await themeToggle.click();
@@ -87,7 +87,7 @@ test.describe('Node.js Website', () => {
8787
expect(['light', 'dark']).toContain(newTheme);
8888

8989
expect(newAriaLabel).toBe(
90-
englishLocale.components.common.themeToggle.label[newTheme]
90+
englishLocale.components.common.themeToggle[newTheme]
9191
);
9292
});
9393

packages/i18n/src/locales/en.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,10 +229,8 @@
229229
"label": "Choose Language"
230230
},
231231
"themeToggle": {
232-
"label": {
233-
"light": "Toggle Light Mode",
234-
"dark": "Toggle Dark Mode"
235-
}
232+
"light": "Switch to Light Mode",
233+
"dark": "Switch to Dark Mode"
236234
}
237235
},
238236
"metabar": {

0 commit comments

Comments
 (0)