Add support for argument mutation in complex argument functions #22
+118
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-id
force-pushed
the
simon-id/fix_arguments_mutation
branch
from
d207977 to
3714811
Compare
simon-id
commented
Jun 13, 2025
simon-id
commented
Jun 13, 2025
Shouldn't a test be failing if that's the case? |
Contributor
Author
|
nah there was no test for argument mutation, so i had to write one, and i only wrote it for function declaration, not for class constructor, i'll try to write one later to see if i'm right, but from what i can tell, the function that handles constructors doesn't go through my code path so i assume it doesn't work. |
timfish
requested changes
Jul 15, 2025
Contributor
There was a problem hiding this comment.
@bizob2828 asked me to review this PR on our temporary fork so I thought I should review this upstream since it is originally your PR!
timfish
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
I think it doesn't work with class constructor rewrite ?
DISCLAIMER:
I have no idea what i'm doing, i'm only trying random stuff until the compiler and the tests are happy. Don't assume anything is correct.